refactor(RHTAPBUGS-919): reuse session in pyxis api calls #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmalina
requested review from
a team,
theflockers,
ralphbean,
davidmogar,
scoheb,
jinqi7,
happybhati and
Troy876
and removed request for
a team
lslebodn
reviewed
Nov 9, 2023
davidmogar
approved these changes
Nov 10, 2023
In my testing, when running this script against qa Pyxis with an sbom that has 113 components, this will yield around 27 % of script runtime reduction. Signed-off-by: Martin Malina <[email protected]>
mmalina
force-pushed
the
pyxis-sbom-optimization-1
branch
from
50abcb5 to
d838863
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing, when running this script against qa Pyxis with an sbom that has 113 components, this will yield around 27 % of script runtime reduction.
Note that I'm also working on batching of the component creation in Pyxis which will bring even more performance increase, but that will be another PR.