Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change image data field #342

Merged
merged 1 commit into from
Dec 13, 2024
Merged

feat: change image data field #342

merged 1 commit into from
Dec 13, 2024

Conversation

jedinym
Copy link
Contributor

@jedinym jedinym commented Dec 13, 2024

Since this script won't use the advisory data anymore, the SBOM data can be simplified.

@jedinym jedinym requested a review from a team as a code owner December 13, 2024 09:55
@jedinym jedinym mentioned this pull request Dec 13, 2024
Merged
@jedinym jedinym force-pushed the sbom-data branch 4 times, most recently from e3c2c46 to 11b2a59 Compare December 13, 2024 11:06
@johnbieren
Copy link
Collaborator

/ok-to-test

@johnbieren
Copy link
Collaborator

Ready for this to be merged?

@johnbieren
Copy link
Collaborator

/retest

@jedinym
Copy link
Contributor Author

jedinym commented Dec 13, 2024

@johnbieren yes, ready to be merged

@johnbieren
Copy link
Collaborator

@johnbieren yes, ready to be merged

Okay, we are using this PR to try to find out why outside contributions get help up on the Red Hat Konflux check with Pending approval but I will make sure it is merged today with or without the check

@johnbieren
Copy link
Collaborator

/ok-to-test

@johnbieren
Copy link
Collaborator

/retest

@johnbieren
Copy link
Collaborator

@jedinym can you force push? We are troubleshooting the pending approval thing. Don't need to change the code... maybe just add a trailing space to the commit message or something and force push

@mmalina
Copy link
Contributor

mmalina commented Dec 13, 2024

@jedinym can you force push? We are troubleshooting the pending approval thing. Don't need to change the code... maybe just add a trailing space to the commit message or something and force push

No need to add spaces - just amend the existing commit and force push.

@johnbieren
Copy link
Collaborator

/ok-to-test

@johnbieren
Copy link
Collaborator

/retest

@jedinym @johnbieren
feat: change image data field
ce9b071 
Since this script won't use the advisory data anymore, the SBOM data can
be simplified.

Signed-off-by: Martin Jediny <[email protected]>
@johnbieren johnbieren merged commit 4a67d0c into konflux-ci:main Dec 13, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnbieren johnbieren johnbieren approved these changes

@mmalina mmalina mmalina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jedinym @johnbieren @mmalina