fix: add missing get-reference-base script for select-oci-auth #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`select-oci-auth` stopped working when the oras image ref was updated to the latest one. The `select-oci-auth` in the oras-container repo was refactored and part of the logic was moved to a new `get-reference-base` script, which it uses. So we need to add that script. Related PR: konflux-ci/oras-container#133 Signed-off-by: Martin Malina <[email protected]>
johnbieren
approved these changes
Dec 12, 2024
|
I can easily reproduce the issue in the latest image: So once we get a new image from this merge, I will verify it's fixed and then update the image for the push-disk-images task |
|
And now with the new image: Looking good. |
mmalina
added a commit
to mmalina/app-interface-deployments
that referenced
this pull request
Dec 12, 2024
The image was updated recently to get a fix for a missing packaging python module: hacbs-release#256 But the new image introduced a regression in the select-oci-auth script. So now it's fixed in this new image: konflux-ci/release-service-utils#341 Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to mmalina/app-interface-deployments
that referenced
this pull request
Dec 12, 2024
The image was updated recently to get a fix for a missing packaging python module: hacbs-release#256 But the new image introduced a regression in the select-oci-auth script. So now it's fixed in this new image: konflux-ci/release-service-utils#341 Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to mmalina/app-interface-deployments
that referenced
this pull request
Dec 12, 2024
The image was updated recently to get a fix for a missing packaging python module: hacbs-release#256 But the new image introduced a regression in the select-oci-auth script. So now it's fixed in this new image: konflux-ci/release-service-utils#341 Signed-off-by: Martin Malina <[email protected]>
This was referenced Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
select-oci-authstopped working when the oras image ref was updated to the latest one.The
select-oci-authin the oras-container repo was refactored and part of the logic was moved to a newget-reference-basescript, which it uses. So we need to add that script.Related PR:
konflux-ci/oras-container#133
The push-disk-images internal task was updated to use the broken image and now it causes issues: hacbs-release/app-interface-deployments#256