fix(KFLUXBUGS-1846): fail get-image-architectures if skopeo failed #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If skopeo inspect fails, the variable would be empty and then the jq query would return an empty string instead of null, so we would assume it's an oci artifact and run oras resolve. If we were unable to fetch the image details with skopeo inspect we should just fail the script. Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to mmalina/release-service-catalog
that referenced
this pull request
Nov 27, 2024
- Bump utils image for improved get-image-architectures: - konflux-ci/release-service-utils#328 - Fix authentication for skopeo inspect when running get-image-architectures - From second component on, it would always use the docker config that was crafted for the previous component, so if the source repo was private, it would fail to fetch the architecture details for that image. As a result, image results would be wrong. Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to mmalina/release-service-catalog
that referenced
this pull request
Nov 27, 2024
- Bump utils image for improved get-image-architectures: - konflux-ci/release-service-utils#328 - Fix authentication for skopeo inspect when running get-image-architectures - From second component on, it would always use the docker config that was crafted for the previous component, so if the source repo was private, it would fail to fetch the architecture details for that image. As a result, image results would be wrong. Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to mmalina/release-service-catalog
that referenced
this pull request
Dec 2, 2024
- Bump utils image for improved get-image-architectures: - konflux-ci/release-service-utils#328 - Fix authentication for skopeo inspect when running get-image-architectures - From second component on, it would always use the docker config that was crafted for the previous component, so if the source repo was private, it would fail to fetch the architecture details for that image. As a result, image results would be wrong. Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to mmalina/release-service-catalog
that referenced
this pull request
Dec 3, 2024
- Bump utils image for improved get-image-architectures: - konflux-ci/release-service-utils#328 - Fix authentication for skopeo inspect when running get-image-architectures - From second component on, it would always use the docker config that was crafted for the previous component, so if the source repo was private, it would fail to fetch the architecture details for that image. As a result, image results would be wrong. Signed-off-by: Martin Malina <[email protected]>
mmalina
added a commit
to konflux-ci/release-service-catalog
that referenced
this pull request
Dec 3, 2024
- Bump utils image for improved get-image-architectures: - konflux-ci/release-service-utils#328 - Fix authentication for skopeo inspect when running get-image-architectures - From second component on, it would always use the docker config that was crafted for the previous component, so if the source repo was private, it would fail to fetch the architecture details for that image. As a result, image results would be wrong. Signed-off-by: Martin Malina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If skopeo inspect fails, the variable would be empty and then the jq query would return an empty string instead of null, so we would assume it's an oci artifact and run oras resolve.
If we were unable to fetch the image details with skopeo inspect we should just fail the script.