Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ISV-5128): also update sbom metadata component purl #315

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

wcheang
Copy link
Contributor

@wcheang wcheang commented Nov 13, 2024

Previously the update-component-sbom script is only updating the component purl in the list of components. But in CycloneDX, there is also a component purl in the metadata.

@wcheang wcheang requested a review from a team as a code owner November 13, 2024 05:38
@wcheang wcheang force-pushed the fix-component-update branch from 9c16bf2 to 749a38e Compare November 13, 2024 06:36
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once `s/componenet/component/g' change is made

@wcheang wcheang force-pushed the fix-component-update branch 4 times, most recently from 419430d to d755290 Compare November 13, 2024 21:13
@wcheang wcheang requested a review from johnbieren November 13, 2024 21:16
@wcheang wcheang force-pushed the fix-component-update branch 2 times, most recently from 1d40cd8 to dcda386 Compare November 18, 2024 15:12
@johnbieren
Copy link
Collaborator

/ok-to-test

Previously the update-component-sbom script is only updating the
component purl in the list of components. But in CycloneDX, there
is also a component purl in the metadata.

Signed-off-by: Wai Cheang <[email protected]>
@wcheang wcheang force-pushed the fix-component-update branch from dcda386 to 19963e2 Compare November 18, 2024 17:40
@johnbieren
Copy link
Collaborator

/ok-to-test

@johnbieren johnbieren merged commit 7048078 into konflux-ci:main Nov 18, 2024
3 of 4 checks passed
@wcheang wcheang deleted the fix-component-update branch November 18, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants