fix: supply manifest list digest to pyxis #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ralphbean
force-pushed
the
multiarch-fix
branch
from
2addb5e to
76d19c5
Compare
mmalina
approved these changes
Nov 12, 2024
ralphbean
force-pushed
the
multiarch-fix
branch
from
76d19c5 to
7d0a0c2
Compare
We're populating containerImage entities incorrectly. I think this has no real effect, but if you look at one that we generate, the manifest_list_digest and manifest_schema2_digest are always the same, but they're not supposed to be. We currently incorrectly always set them to the value of the arch-specific image manifest, when the point is to provide both values, the multi-arch image index manifest as the manifest_list_digest and the arch-specific image manifest as the manifest_schema2_digest. Signed-off-by: Ralph Bean <[email protected]>
ralphbean
force-pushed
the
multiarch-fix
branch
from
7d0a0c2 to
d93b962
Compare
|
This actually brings one potential issue - the manifest_list_digest will no longer be unique - meaning that if we were to search for existing images using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're populating containerImage entities incorrectly.
I think this has no real effect, but if you look at one that we generate, the manifest_list_digest and manifest_schema2_digest are always the same, but they're not supposed to be. We currently incorrectly always set them to the value of the arch-specific image manifest, when the point is to provide both values, the multi-arch image index manifest as the manifest_list_digest and the arch-specific image manifest as the manifest_schema2_digest.