Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(KFLUXBUGS-1848): associate existing images with a new repository #303

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix(KFLUXBUGS-1848): associate existing images with a new repository #303

merged 1 commit into from
Nov 8, 2024

Conversation

ralphbean
Copy link
Member

@ralphbean ralphbean commented Nov 8, 2024 •
edited
Loading

This adds a new behavior.

If asked to create an image associated with a repository, and the image does not exist at all - then create it, as before.

If the image does exist, but is not associated with the desired repository, then submit a PATCH request to update it, adding the desired repository.

This is related to #300 and KFLUXBUGS-1848.

@ralphbean ralphbean requested a review from a team as a code owner November 8, 2024 01:32
@ralphbean ralphbean changed the title feat: associate existing images with a new repository fix(KFLUXBUGS-1848): associate existing images with a new repository Nov 8, 2024
@ralphbean ralphbean force-pushed the patch-repository branch 4 times, most recently from d04a890 to a5f9d9f Compare November 8, 2024 02:32
@ralphbean
Copy link
Member Author

Needs a run of black and (maybe) a rebase.

@ralphbean
fix(KFLUXBUGS-1848): associate existing images with a new repository
bfc4cf2 
This adds a new behavior.

If asked to create an image associated with a repository, and the image
does not exist at all - then create it, as before.

If the image does exist, but is not associated with the desired
repository, then submit a PATCH request to update it, adding the desired
repository.

Signed-off-by: Ralph Bean <[email protected]>
@mmalina mmalina merged commit 6963f58 into main Nov 8, 2024
3 checks passed
@mmalina mmalina deleted the patch-repository branch November 8, 2024 13:31
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 8, 2024
@mmalina
refactor: patching ContainerImage to add repositories
3ce907f 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
@mmalina mmalina mentioned this pull request Nov 8, 2024
Merged
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 8, 2024
@mmalina
refactor: patching ContainerImage to add repositories
c5315ef 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
@johnbieren
Copy link
Collaborator

https://issues.redhat.com/browse/RELEASE-793 added for unit tests

mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 22, 2024
@mmalina
refactor: patching ContainerImage to add repositories
7c7a842 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 22, 2024
@mmalina
refactor: patching ContainerImage to add repositories
be2099f 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 22, 2024
@mmalina
refactor: patching ContainerImage to add repositories
17837d2 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 22, 2024
@mmalina
refactor: patching ContainerImage to add repositories
0d8ec40 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 25, 2024
@mmalina
refactor: patching ContainerImage to add repositories
c9aaa3b 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 25, 2024
@mmalina
refactor: patching ContainerImage to add repositories
5f84619 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 25, 2024
@mmalina
refactor: patching ContainerImage to add repositories
83fb766 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 27, 2024
@mmalina
refactor: patching ContainerImage to add repositories
9a86ba0 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit to mmalina/release-service-utils that referenced this pull request Nov 27, 2024
@mmalina
refactor: patching ContainerImage to add repositories
3a0bd77 
This is a followup of what was done in konflux-ci#303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Also, this adds tests for pyxis.patch
- RELEASE-1285

Signed-off-by: Martin Malina <[email protected]>
mmalina added a commit that referenced this pull request Nov 27, 2024
@mmalina
refactor: patching ContainerImage to add repositories (#305)
dc0f89c 
This is a followup of what was done in #303

Most notably:

- rename the image_already_exists to find_image
  to reflect what it does - it used to return bool, now it returns
  the image if found.
- only include the repositories field in the patch payload
- for consistency, create the same two repo entries when adding
  a new repository like we do when creating a brand new image

Also, this adds tests for pyxis.patch
- RELEASE-1285

Signed-off-by: Martin Malina <[email protected]>
@mmalina mmalina mentioned this pull request Nov 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalina mmalina mmalina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralphbean @johnbieren @mmalina