Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RELEASE-1083): linting issues in push-snapshot #754

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mmalina
Copy link
Contributor

@mmalina mmalina commented Dec 17, 2024

Describe your changes

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

Copy link

openshift-ci bot commented Dec 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mmalina mmalina force-pushed the push-snapshot-lint branch 8 times, most recently from ce4f0a5 to 3bce5de Compare December 18, 2024 13:03
@mmalina mmalina marked this pull request as ready for review December 18, 2024 13:04
@mmalina mmalina requested a review from a team as a code owner December 18, 2024 13:04
@openshift-ci openshift-ci bot added the lgtm label Dec 18, 2024
@mmalina mmalina enabled auto-merge (squash) December 18, 2024 13:57
@openshift-ci openshift-ci bot removed the lgtm label Dec 18, 2024
Copy link

openshift-ci bot commented Dec 18, 2024

New changes are detected. LGTM label has been removed.

@mmalina
Copy link
Contributor Author

mmalina commented Dec 19, 2024

There was no e2e log in the failed test.

@mmalina mmalina merged commit 1a5b02e into konflux-ci:development Dec 19, 2024
8 checks passed
@mmalina mmalina deleted the push-snapshot-lint branch December 19, 2024 11:54
midnightercz pushed a commit to midnightercz/release-service-catalog that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants