Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(RELEASE-1042): add publish-index-image internal task and pipeline #736

Merged
merged 1 commit into from
Dec 12, 2024
Merged

chore(RELEASE-1042): add publish-index-image internal task and pipeline #736

merged 1 commit into from
Dec 12, 2024

Conversation

johnbieren
Copy link
Collaborator

@johnbieren johnbieren commented Dec 10, 2024 •
edited
Loading

This commit moves the publish-index-image pipeline and task from the app-interface repo to the internal directory of this repo. It also adds tests and a README with it.

Describe your changes

Relevant Jira

Checklist before requesting a review

  • I have marked as draft or added do not merge label if there's a dependency PR
    • If you want reviews on your draft PR, you can add reviewers or add the release-service-maintainers handle if you are unsure who to tag
  • My commit message includes Signed-off-by: My name <email>
  • I have bumped the task/pipeline version string and updated changelog in the relevant README
  • I read CONTRIBUTING.MD and commit formatting

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@johnbieren johnbieren force-pushed the release1042 branch 8 times, most recently from 20a4f3c to ca7a214 Compare December 10, 2024 20:49
@johnbieren johnbieren marked this pull request as ready for review December 10, 2024 20:54
@johnbieren johnbieren requested a review from a team as a code owner December 10, 2024 20:54
This was referenced Dec 10, 2024
Merged
Open
@johnbieren
Copy link
Collaborator Author

/retest

@johnbieren
Copy link
Collaborator Author

/retest

2 similar comments
@johnbieren
Copy link
Collaborator Author

/retest

@johnbieren
Copy link
Collaborator Author

/retest

@johnbieren
Copy link
Collaborator Author

/retest

2 similar comments
@johnbieren
Copy link
Collaborator Author

/retest

@johnbieren
Copy link
Collaborator Author

/retest

@johnbieren
Copy link
Collaborator Author

/retest
weird panic

@johnbieren
Copy link
Collaborator Author

/retest

@mmalina
Copy link
Contributor

mmalina commented Dec 12, 2024

@johnbieren can you confirm and check the checkboxes in the PR description? ;) Also, are there already PRs for removing it from the other repo? Can you reference them?

@johnbieren
Copy link
Collaborator Author

johnbieren commented Dec 12, 2024 •
edited by openshift-ci bot
Loading

This was referenced
[ chore(RELEASE-1042): remove publish-index-image tekton resources hacbs-release/app-interface-deployments#257](/hacbs-release/app-interface-deployments/pull/257)

This was referenced 2 days ago
[ chore(RELEASE-1042): remove publish-index-image tekton resources hacbs-release/app-interface-deployments#257](/hacbs-release/app-interface-deployments/pull/257)

@johnbieren
Copy link
Collaborator Author

/retest

@mmalina
Copy link
Contributor

mmalina commented Dec 12, 2024 •
edited by openshift-ci bot
Loading

This was referenced
[ chore(RELEASE-1042): remove publish-index-image tekton resources hacbs-release/app-interface-deployments#257](/hacbs-release/app-interface-deployments/pull/257)

This was referenced 2 days ago
[ chore([RELEASE-1042](https://issues.redhat.com//browse/RELEASE-1042)): remove publish-index-image tekton resources hacbs-release/app-interface-deployments#257](/hacbs-release/app-interface-deployments/pull/257)

Yeah, ok, but that can get really lost in all the comments - it's nice to have that in the PR description.

@openshift-ci openshift-ci bot added the lgtm label Dec 12, 2024
@johnbieren
chore(RELEASE-1042): add publish-index-image internal task and pipeline
38a69b1 
This commit moves the publish-index-image pipeline and task
from the app-interface repo to the internal directory of this
repo. It also adds tests and a README with it.

Signed-off-by: Johnny Bieren <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Dec 12, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 12, 2024

New changes are detected. LGTM label has been removed.

@johnbieren johnbieren merged commit 4442af2 into konflux-ci:development Dec 12, 2024
8 checks passed
@johnbieren johnbieren deleted the release1042 branch December 12, 2024 14:48
midnightercz pushed a commit to midnightercz/release-service-catalog that referenced this pull request Jan 3, 2025
@johnbieren @midnightercz
chore(RELEASE-1042): add publish-index-image internal task and pipeli…
6380ea2 
…ne (konflux-ci#736)

This commit moves the publish-index-image pipeline and task
from the app-interface repo to the internal directory of this
repo. It also adds tests and a README with it.

Signed-off-by: Johnny Bieren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmalina mmalina mmalina approved these changes

Assignees

@mmalina mmalina

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@johnbieren @mmalina