feat(SPSTRAT-465): add task for marketplacesvm

[JAVGan]

This commit introduces a new task named marketplaces-push-disk-images which will be used to deliver disk images to various cloud marketplaces using the marketplacesvm_push_wrapper.

Refers to SPSTRAT-465

[openshift-ci]

Hi @JAVGan. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[JAVGan]

@lslebodn FYI moved here.

@johnbieren is there a way to test that?

[lslebodn]

Can we somewhere in the code validate staging structure with pushsource-ls
as we discussed in konflux-ci/release-service-utils#326 (comment)?

[JAVGan]

Can we somewhere in the code validate staging structure with pushsource-ls as we discussed in konflux-ci/release-service-utils#326 (comment)?

Thanks! I forgot it last time. Now it's added 😄

[JAVGan]

@mmalina @johnbieren I've added a single test to ensure the task works, but honestly since I'm very new to testing stuff on Konflux I'm really not sure whether I did it correctly or not... What I did was based in the other tasks with some adaptations for our use cases, please let me know what I need to fix/change and I'll do it.

However, by implementing such tests I ended up with the following questions:

1. As asked earlier do we need to have our task as internal? We're just using oras pull and select-oci-auth to deal with quay.io and for the rest we don't need anything from within the firewall... If you agree the task can be external I'll move it out from the internal directory.
2. By looking at the tests from push-disk-images I noticed you have 2 different JSON files: snapshot_spec.json and data.json which are combined here. I assumed the snapshot_json was incoming as a whole, like what we discussed before on slack channel and my task assumes it's a single JSON as well... Should I update it to receive two JSONs aside from our starmap mappings? It would end up with 3 JSONs for the parameters if yes...
3. Is there a way I can "validate" or "run the tests" in some place before asking you guys to run it on CI? I believe it would be faster to catch errors and fix stuff.

[johnbieren]

/ok-to-test

[johnbieren]

E2E irrelevant here. Will merge tomorrow unless @mmalina comments something to change

[johnbieren]

/ok-to-test

[JAVGan]

@johnbieren @mmalina Fixed an unbound variable

[johnbieren]

/ok-to-test

[konflux-ci-qe-bot]

@JAVGan: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name	Status	Rerun command	Build Log	Test Log
konflux-e2e-tests-catalog-xxhfx	Failed	/retest	View Pipeline Log	View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

1. Install ORAS (see the ORAS installation guide).
2. Download artifacts with the following commands:

mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-xxhfx

[mmalina]

One last small comment and then it should be ready to merge.