Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(KONFLUX-4892): supply layer size information to pyxis #634

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

ralphbean
Copy link
Member

@ralphbean ralphbean commented Oct 22, 2024

This is meant to be paired with a change in the step image: konflux-ci/release-service-utils#284

If the layers of the image are found to be gzip compressed, then pull them, decompress them, and include information about their decompressed digests and sizes in the manifest provided to the pyxis script.

Normal images will always have the layers compressed. If they are not compressed, this will not save the uncompressed data in Pyxis.

@ralphbean ralphbean requested a review from a team as a code owner October 22, 2024 20:19
@ralphbean ralphbean marked this pull request as draft October 22, 2024 20:19
@ralphbean ralphbean force-pushed the pyxis-layer-sizes branch 7 times, most recently from e255e74 to 4e95304 Compare October 22, 2024 23:43
@ralphbean ralphbean marked this pull request as ready for review October 22, 2024 23:44
@ralphbean
Copy link
Member Author

I think this is ready for review now (aside from the obvious wrong image which we'll replace once konflux-ci/release-service-utils#284 merges).

@ralphbean ralphbean force-pushed the pyxis-layer-sizes branch 3 times, most recently from abbc6db to 9b854aa Compare October 24, 2024 22:55
@ralphbean
Copy link
Member Author

/retest

johnbieren
johnbieren previously approved these changes Oct 30, 2024
Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase (conflicting file) but otherwise lgtm

@johnbieren
Copy link
Collaborator

Happy to merge this without e2e once rebased. The conflict is due to a unit test change so e2e will execute just as it has now (and passed). Can you squash this down to one commit though?

@ralphbean
Copy link
Member Author

OK - squashed and rebased.

@johnbieren
Copy link
Collaborator

Needs another rebase unfortunately - we were rushing to get another bug fix PR in before our weekly promotion

@ralphbean
Copy link
Member Author

Hey, you should consider merge queues like the build-definitions repo does. They might make this whole manual rebase churn disappear.

We had to make one or two changes to the .tekton/ definitions to make it work.

This is meant to be paired with a change in the step image:
konflux-ci/release-service-utils#284

If the layers of the image are found to be gzip compressed, then pull
them, decompress them, and include information about their decompressed
digests and sizes in the manifest provided to the pyxis script.

Signed-off-by: Ralph Bean <[email protected]>
@ralphbean ralphbean enabled auto-merge (squash) October 30, 2024 17:43
@johnbieren
Copy link
Collaborator

Hey, you should consider merge queues like the build-definitions repo does. They might make this whole manual rebase churn disappear.

We had to make one or two changes to the .tekton/ definitions to make it work.

We have https://issues.redhat.com/browse/RELEASE-1142 open for exactly that, just no time to work on it. I will link your comment on the ticket

Copy link
Collaborator

@johnbieren johnbieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/retest

@openshift-ci openshift-ci bot added the lgtm label Oct 30, 2024
@johnbieren johnbieren disabled auto-merge October 30, 2024 18:00
@johnbieren
Copy link
Collaborator

Merging without e2e for reasons already mentioned

@johnbieren johnbieren merged commit ef67258 into development Oct 30, 2024
6 of 8 checks passed
@johnbieren johnbieren deleted the pyxis-layer-sizes branch October 30, 2024 18:00
@konflux-ci-qe-bot
Copy link

@ralphbean: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-tests-catalog-6wpxr Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-6wpxr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants