-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(KONFLUX-4892): supply layer size information to pyxis #634
Conversation
e255e74
to
4e95304
Compare
I think this is ready for review now (aside from the obvious wrong |
abbc6db
to
9b854aa
Compare
9b854aa
to
dd588c7
Compare
b40f121
to
cf61a01
Compare
f9f66fc
to
c67e15c
Compare
/retest |
c67e15c
to
5babb41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase (conflicting file) but otherwise lgtm
Happy to merge this without e2e once rebased. The conflict is due to a unit test change so e2e will execute just as it has now (and passed). Can you squash this down to one commit though? |
5babb41
to
b42536d
Compare
OK - squashed and rebased. |
Needs another rebase unfortunately - we were rushing to get another bug fix PR in before our weekly promotion |
Hey, you should consider merge queues like the build-definitions repo does. They might make this whole manual rebase churn disappear. We had to make one or two changes to the |
This is meant to be paired with a change in the step image: konflux-ci/release-service-utils#284 If the layers of the image are found to be gzip compressed, then pull them, decompress them, and include information about their decompressed digests and sizes in the manifest provided to the pyxis script. Signed-off-by: Ralph Bean <[email protected]>
b42536d
to
19e62fe
Compare
We have https://issues.redhat.com/browse/RELEASE-1142 open for exactly that, just no time to work on it. I will link your comment on the ticket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/retest
Merging without e2e for reasons already mentioned |
@ralphbean: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/release-service-catalog:konflux-e2e-tests-catalog-6wpxr |
This is meant to be paired with a change in the step image: konflux-ci/release-service-utils#284
If the layers of the image are found to be gzip compressed, then pull them, decompress them, and include information about their decompressed digests and sizes in the manifest provided to the pyxis script.
Normal images will always have the layers compressed. If they are not compressed, this will not save the uncompressed data in Pyxis.