chore(RHTAPWATCH-1137): send messages to sns #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yftacherzog
reviewed
Jul 16, 2024
avi-biton
force-pushed
the
sns
branch
2 times, most recently
from
d5a797b to
b4c4118
Compare
yftacherzog
reviewed
Jul 17, 2024
yftacherzog
reviewed
Jul 17, 2024
- Add notifier interface - Add notifier to the reconciler - Implement SNSNotifier to send messages to Amazon SNS - Add mock notifier and use it in integration tests - Add unit tests Signed-off-by: Avi Biton <[email protected]>
yftacherzog
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parameters to communicate with AWS SNS are retrieved from environment variables:
to create a client
In addition, I added: