Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go): bump k8s.io/apimachinery from 0.29.4 to 0.31.4 #958

Closed

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 11, 2024

Bumps k8s.io/apimachinery from 0.29.4 to 0.31.4.

Commits
  • a8f449e Falls back to SPDY for gorilla/websocket https proxy error
  • 62791ec Merge pull request #125571 from liggitt/filter-auth-02-sar
  • cc2ba35 add field and label selectors to authorization attributes
  • ce76a8f generate
  • 35052c5 add subjectaccessreview field and label selectors
  • ab06869 Merge pull request #126105 from benluddy/cbor-framer
  • 429f4e4 Implement runtime.Framer for CBOR Sequences.
  • d7e1c53 Merge pull request #126018 from aroradaman/bump-k8s-utils
  • 07cb122 Merge pull request #125748 from benluddy/cbor-custom-marshalers
  • dd17456 bump k8s.io/utils
  • Additional commits viewable in compare view

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
k8s.io/apimachinery [>= 0.27.a, < 0.28]

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.29.4 to 0.31.4.
- [Commits](kubernetes/apimachinery@v0.29.4...v0.31.4)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels Dec 11, 2024
@dependabot dependabot bot requested a review from MartinBasti December 11, 2024 17:08
Copy link

openshift-ci bot commented Dec 11, 2024

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a konflux-ci member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hongweiliu17
Copy link
Contributor

@dependabot rebase

@hongweiliu17
Copy link
Contributor

We need to fix the issues in go linters and Checkout sources, but I check out the code to local env and meet issue in vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:108:9

integration-pr-958 % make test
/Users/hongliu/HAS/integration-pr-958/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
/Users/hongliu/HAS/integration-pr-958/bin/controller-gen object:headerFile="hack/boilerplate.go.txt" paths="./..."
go fmt ./...
go vet ./...
# sigs.k8s.io/controller-runtime/pkg/internal/controller
vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go:108:9: not enough arguments in call to fn
	have (interface{})
	want (context.Context, interface{})
# sigs.k8s.io/controller-runtime/pkg/webhook/admission
vendor/sigs.k8s.io/controller-runtime/pkg/webhook/admission/webhook.go:158:9: not enough arguments in call to fn
	have (interface{})
	want (context.Context, interface{})
make: *** [vet] Error 1

If we need to also upgrade the version of vendor/sigs.k8s.io/controller-runtime/pkg/internal/controller/controller.go

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 12, 2024

Superseded by #963.

@dependabot dependabot bot closed this Dec 12, 2024
@dependabot dependabot bot deleted the dependabot/go_modules/k8s.io/apimachinery-0.31.4 branch December 12, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file go Pull requests that update Go code needs-ok-to-test size: XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant