-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(STONEINTG-1086): annotate build PLR when failing to create snapshot #936
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
=======================================
Coverage ? 66.75%
=======================================
Files ? 43
Lines ? 5809
Branches ? 0
=======================================
Hits ? 3878
Misses ? 1587
Partials ? 344 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Does this mean that the snapshot quota issue will be now reflected in annotations? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
a72f234
to
2d0171a
Compare
Yes, at least users can see the error if they check build plr. And next they can know the failure from git pr/mr once we implement STONEINTG-996. |
2d0171a
to
6de7e8f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
6de7e8f
to
8b7fcb8
Compare
Signed-off-by: Hongwei Liu <[email protected]>
8b7fcb8
to
f5b81b0
Compare
Signed-off-by: Hongwei Liu [email protected]
Maintainers will complete the following section