Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(STONEINTG-1086): annotate build PLR when failing to create snapshot #936

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

hongweiliu17
Copy link
Contributor

Signed-off-by: Hongwei Liu [email protected]

Maintainers will complete the following section

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@b3d9c11). Learn more about missing BASE report.

Files with missing lines Patch % Lines
.../controller/buildpipeline/buildpipeline_adapter.go 66.66% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #936   +/-   ##
=======================================
  Coverage        ?   66.75%           
=======================================
  Files           ?       43           
  Lines           ?     5809           
  Branches        ?        0           
=======================================
  Hits            ?     3878           
  Misses          ?     1587           
  Partials        ?      344           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@jsztuka
Copy link
Contributor

jsztuka commented Nov 20, 2024

Does this mean that the snapshot quota issue will be now reflected in annotations?

Copy link
Contributor

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hongweiliu17
Copy link
Contributor Author

Does this mean that the snapshot quota issue will be now reflected in annotations?

Yes, at least users can see the error if they check build plr. And next they can know the failure from git pr/mr once we implement STONEINTG-996.

Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants