Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(STONEINTG-1065): let users rerun ALL tests #912

Merged
merged 1 commit into from
Nov 22, 2024
Merged

feat(STONEINTG-1065): let users rerun ALL tests #912

merged 1 commit into from
Nov 22, 2024

Conversation

dheerajodha
Copy link
Member

  • Before this commit, a user can only rerun one test at a time by adding the "run" label on snapshot with the name of ITS they want to rerun.
  • After this commit, a user can add the value of "all" in the "run" label of snapshot to automatically rerun ALL the tests easily.

Maintainers will complete the following section

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Oct 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@dheerajodha dheerajodha force-pushed the STONEINTG-1065 branch 2 times, most recently from 9048489 to aa18e05 Compare November 4, 2024 08:59
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 44.70588% with 47 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@3330c2d). Learn more about missing BASE report.

Files with missing lines Patch % Lines
internal/controller/snapshot/snapshot_adapter.go 43.05% 30 Missing and 11 partials ⚠️
loader/loader.go 57.14% 2 Missing and 1 partial ⚠️
loader/loader_mock.go 50.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #912   +/-   ##
=======================================
  Coverage        ?   66.56%           
=======================================
  Files           ?       43           
  Lines           ?     5853           
  Branches        ?        0           
=======================================
  Hits            ?     3896           
  Misses          ?     1606           
  Partials        ?      351

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@dheerajodha dheerajodha marked this pull request as ready for review November 5, 2024 13:06
@dheerajodha dheerajodha force-pushed the STONEINTG-1065 branch 3 times, most recently from e1ce8e4 to 433cd57 Compare November 6, 2024 09:03
dirgim
dirgim approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside the optional suggestion

@openshift-ci openshift-ci bot added the lgtm label Nov 8, 2024
@dirgim
Copy link
Collaborator

dirgim commented Nov 8, 2024

/retest

jsztuka
jsztuka approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hongweiliu17
hongweiliu17 approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside the nice-to-have.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 21, 2024

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci bot removed the lgtm label Nov 21, 2024
@dheerajodha
feat(STONEINTG-1065): let users rerun ALL tests
536364f 
* Before this commit, a user can only rerun
  one test at a time by adding the "run"
  label on snapshot with the name of ITS
  they want to rerun.
* After this commit, a user can add the value
  of "all" in the "run" label of snapshot to
  automatically rerun ALL the tests easily.

Signed-off-by: Dheeraj<djodha@redhat>
@dheerajodha
Copy link
Member Author

/retest

@dheerajodha dheerajodha merged commit 164faee into konflux-ci:main Nov 22, 2024
12 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Nov 22, 2024
Merged
@dirgim dirgim mentioned this pull request Nov 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsztuka jsztuka jsztuka approved these changes

@kasemAlem kasemAlem kasemAlem approved these changes

@hongweiliu17 hongweiliu17 hongweiliu17 approved these changes

@dirgim dirgim dirgim approved these changes

@Josh-Everett Josh-Everett Josh-Everett approved these changes

@sonam1412 sonam1412 Awaiting requested review from sonam1412 sonam1412 is a code owner

@14rcole 14rcole Awaiting requested review from 14rcole 14rcole is a code owner

@jencull jencull Awaiting requested review from jencull jencull is a code owner

@chipspeak chipspeak Awaiting requested review from chipspeak chipspeak is a code owner

Assignees

@Josh-Everett Josh-Everett

@dirgim dirgim

@hongweiliu17 hongweiliu17

@kasemAlem kasemAlem

@jsztuka jsztuka

Labels
size: M size: XL size: XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dheerajodha @codecov-commenter @dirgim @Josh-Everett @hongweiliu17 @kasemAlem @jsztuka