Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(STONEINTG-611): stop extensive logging about failed SEB #320

Merged
merged 1 commit into from
Sep 15, 2023
Merged

fix(STONEINTG-611): stop extensive logging about failed SEB #320

merged 1 commit into from
Sep 15, 2023

Conversation

MartinBasti
Copy link
Collaborator

We don't need so many logs about failed SEB provisioning, it floods logs with repetetive errors.

Maintainers will complete the following section

  • Commit messages are descriptive enough (hints)
  • Code coverage from testing does not decrease and new code is covered
  • Controllers diagrams are updated when PR changes controllers code (if applicable)

@MartinBasti
fix(STONEINTG-611): stop extensive logging about failed SEB
62093da 
We don't need so many logs about failed SEB provisioning, it floods logs
with repetetive errors.

Signed-off-by: Martin Basti <[email protected]>
dheerajodha
dheerajodha approved these changes Sep 15, 2023
View reviewed changes
Copy link
Member

@dheerajodha dheerajodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM <3

@openshift-ci openshift-ci bot added the lgtm label Sep 15, 2023
@MartinBasti MartinBasti merged commit d768469 into konflux-ci:main Sep 15, 2023
9 checks passed
@MartinBasti MartinBasti deleted the remove-seb-retry-log branch September 15, 2023 17:53
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheerajodha dheerajodha dheerajodha approved these changes

@14rcole 14rcole 14rcole approved these changes

@hongweiliu17 hongweiliu17 Awaiting requested review from hongweiliu17 hongweiliu17 is a code owner

@sonam1412 sonam1412 Awaiting requested review from sonam1412 sonam1412 is a code owner

@Josh-Everett Josh-Everett Awaiting requested review from Josh-Everett Josh-Everett is a code owner

Assignees

@14rcole 14rcole

@dheerajodha dheerajodha

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinBasti @14rcole @dheerajodha