fix(stoneintg-564): ignore empty values #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14rcole
requested review from
Josh-Everett,
MartinBasti,
jinqi7,
dirgim,
hongweiliu17,
dheerajodha,
jsztuka,
jencull and
sonam1412
MartinBasti
requested changes
Sep 15, 2023
Previously empty values in the violations graphs were reported as zero. This is because in order to calculate the percentage of requests meeting our thresholds we divide the "good" requests by the total requests. If there are no total requests then grafana sets 0/0 to 0 rather than dividing by 0. This change ignores the empty values and changes the display from a line to bars to improve readability. Signed-off-by: Ryan Cole <[email protected]>
|
Five years and I still can't commit things properly. Fixed now, I double-checked and I only saw those two SLOs having this issue |
14rcole
force-pushed
the
stoneintg-564
branch
from
b4698fe to
8bfeb9c
Compare
MartinBasti
approved these changes
Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously empty values in the violations graphs were reported as zero. This is because in order to calculate the percentage of requests meeting our thresholds we divide the "good" requests by the total requests. If there are no total requests then grafana sets 0/0 to 0 rather than dividing by 0. This change ignores the empty values and changes the display from a line to bars to improve readability.
Maintainers will complete the following section