Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(STONEINTG-534): add SLI SnapshotEnvirontBinding to grafana #315

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

jinqi7
Copy link
Contributor

@jinqi7 jinqi7 commented Sep 14, 2023

Add panel for SnapshotEnvironmentBinding in grafana

Maintainers will complete the following section

  • Commit messages are descriptive enough (hints)
  • Code coverage from testing does not decrease and new code is covered
  • Controllers diagrams are updated when PR changes controllers code (if applicable)

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.06% ⚠️

Comparison is base (d9a97d6) 69.10% compared to head (5bca777) 69.05%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
- Coverage   69.10%   69.05%   -0.06%     
==========================================
  Files          38       38              
  Lines        3658     3658              
==========================================
- Hits         2528     2526       -2     
- Misses        872      874       +2     
  Partials      258      258              
Files Changed Coverage Δ
status/reporters.go 62.37% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonam1412
Copy link
Collaborator

@jinqi7 Can you please correct the jira ticket number on the commit message ?

@jinqi7 jinqi7 changed the title feat(STONEINTG-524): add SLI SnapshotEnvirontBinding to grafana feat(STONEINTG-534): add SLI SnapshotEnvirontBinding to grafana Sep 14, 2023
@MartinBasti
Copy link
Collaborator

you updated only PR, git commit still contains wrong issue number

@MartinBasti
Copy link
Collaborator

/retest

Copy link
Contributor

@jsztuka jsztuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jinqi7 jinqi7 merged commit a404aca into konflux-ci:main Sep 19, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants