Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix spelling of Succeeded #312

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

14rcole
Copy link
Collaborator

@14rcole 14rcole commented Sep 13, 2023

Maintainers will complete the following section

  • Commit messages are descriptive enough (hints)
  • Code coverage from testing does not decrease and new code is covered
  • Controllers diagrams are updated when PR changes controllers code (if applicable)

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 93.33% and project coverage change: +1.01% 🎉

Comparison is base (d9a97d6) 69.10% compared to head (9962843) 70.12%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #312      +/-   ##
==========================================
+ Coverage   69.10%   70.12%   +1.01%     
==========================================
  Files          38       38              
  Lines        3658     3658              
==========================================
+ Hits         2528     2565      +37     
+ Misses        872      844      -28     
+ Partials      258      249       -9     
Files Changed Coverage Δ
controllers/snapshot/snapshot_adapter.go 56.44% <0.00%> (+1.47%) ⬆️
...integrationpipeline/integrationpipeline_adapter.go 64.17% <100.00%> (+4.10%) ⬆️
gitops/snapshot.go 79.11% <100.00%> (ø)
status/reporters.go 62.37% <100.00%> (ø)

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sonam1412 sonam1412 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@14rcole 14rcole merged commit 5b429ef into konflux-ci:main Sep 14, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants