Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new grafana panel for release latency seconds #310

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat: new grafana panel for release latency seconds #310

merged 1 commit into from
Oct 2, 2023

Conversation

jencull
Copy link
Contributor

@jencull jencull commented Sep 13, 2023 •
edited by dirgim
Loading

new metric release latency seconds
new grafana panel of same name
measures latency between integration tests
completing and release creation

Maintainers will complete the following section

  • Commit messages are descriptive enough (hints)
  • Code coverage from testing does not decrease and new code is covered
  • Controllers diagrams are updated when PR changes controllers code (if applicable)

MartinBasti
MartinBasti reviewed Sep 13, 2023
View reviewed changes
metrics/integration.go Outdated Show resolved Hide resolved
MartinBasti
MartinBasti reviewed Sep 13, 2023
View reviewed changes
metrics/integration.go Outdated Show resolved Hide resolved
jinqi7
jinqi7 reviewed Sep 13, 2023
View reviewed changes
Copy link
Contributor

@jinqi7 jinqi7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test is needed for the newly added metric.

@codecov
Copy link

codecov bot commented Sep 13, 2023 •
edited
Loading

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.03% ⚠️

Comparison is base (bec4cb8) 69.13% compared to head (36e39be) 69.10%.
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #310      +/-   ##
==========================================
- Coverage   69.13%   69.10%   -0.03%     
==========================================
  Files          38       38              
  Lines        3658     3661       +3     
==========================================
+ Hits         2529     2530       +1     
- Misses        872      881       +9     
+ Partials      257      250       -7
Files Changed Coverage Δ
metrics/integration.go 81.57% <33.33%> (-4.14%) ⬇️

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinBasti
Copy link
Collaborator

MartinBasti commented Sep 13, 2023 •
edited by jencull
Loading

[ x] Code coverage from testing does not decrease and new code is covered

Why is this checked? From coverage report new code isn't covered, also as mentioned Jing tests are missing

This initial commit adds the histogram to json and metrics files and results in a -0.03 code coverage difference. Its been marked as 'code coverage not decreased' for this initial commit as change is small and additional change is expected once further work is undertaken.

@jencull
Copy link
Contributor Author

jencull commented Sep 13, 2023

/hold

@jencull
Copy link
Contributor Author

jencull commented Sep 20, 2023

/retest

@jencull jencull closed this Sep 20, 2023
@jencull jencull reopened this Sep 20, 2023
14rcole
14rcole reviewed Sep 20, 2023
View reviewed changes
gitops/snapshot.go Outdated Show resolved Hide resolved
14rcole
14rcole reviewed Sep 26, 2023
View reviewed changes
metrics/integration.go Outdated Show resolved Hide resolved
MartinBasti
MartinBasti reviewed Sep 27, 2023
View reviewed changes
gitops/snapshot.go Outdated Show resolved Hide resolved
MartinBasti
MartinBasti reviewed Sep 27, 2023
View reviewed changes
gitops/snapshot.go Outdated Show resolved Hide resolved
@jencull jencull requested a review from MartinBasti October 2, 2023 08:15
@jencull
feat(STONEINTG-532): add release latency seconds metrics
521ef7a 
add grafana panel
add calculating function in metrics/integration.go
functons to calculate start time in gitops/snapshot
unit tests written for all new functions

Signed-off-by: Jennefer Cullinan <[email protected]>
@jencull jencull requested a review from dirgim October 2, 2023 11:53
dirgim
dirgim approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2023
@jencull jencull merged commit 92c8f94 into konflux-ci:main Oct 2, 2023
9 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Oct 2, 2023
Merged
@jencull jencull deleted the stoneintg-532 branch October 3, 2023 08:47
@jencull jencull restored the stoneintg-532 branch October 5, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirgim dirgim dirgim approved these changes

@MartinBasti MartinBasti MartinBasti approved these changes

@Josh-Everett Josh-Everett Josh-Everett approved these changes

@hongweiliu17 hongweiliu17 Awaiting requested review from hongweiliu17 hongweiliu17 is a code owner

@sonam1412 sonam1412 Awaiting requested review from sonam1412 sonam1412 is a code owner

@jsztuka jsztuka Awaiting requested review from jsztuka jsztuka is a code owner

@dheerajodha dheerajodha Awaiting requested review from dheerajodha dheerajodha is a code owner

@jinqi7 jinqi7 Awaiting requested review from jinqi7

@14rcole 14rcole Awaiting requested review from 14rcole 14rcole is a code owner

Assignees

@Josh-Everett Josh-Everett

@MartinBasti MartinBasti

@dirgim dirgim

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jencull @MartinBasti @14rcole @Josh-Everett @jinqi7 @dirgim @openshift-merge-robot