Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(STONEINTG-524): update NS of pipelines-as-code secret #304

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix(STONEINTG-524): update NS of pipelines-as-code secret #304

merged 1 commit into from
Sep 11, 2023

Conversation

hongweiliu17
Copy link
Contributor

@hongweiliu17 hongweiliu17 commented Sep 11, 2023 •
edited
Loading

  • update NS of pipelines-as-code secret since the NS has been changed to openshift-pipelines

Maintainers will complete the following section

  • Commit messages are descriptive enough (hints)
  • Code coverage from testing does not decrease and new code is covered
  • Controllers diagrams are updated when PR changes controllers code (if applicable)

@hongweiliu17
fix(STONEINTG-524): update NS of pipelines-as-code secret
cafa2a2 
* update NS of pipelines-as-code secret since the NS has been
  changed to openshift-pipelines

Signed-off-by: Hongwei Liu <[email protected]>
@openshift-ci openshift-ci bot added the lgtm label Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.23% 🎉

Comparison is base (d1595e8) 67.98% compared to head (cafa2a2) 69.21%.
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #304      +/-   ##
==========================================
+ Coverage   67.98%   69.21%   +1.23%     
==========================================
  Files          38       38              
  Lines        3658     3658              
==========================================
+ Hits         2487     2532      +45     
+ Misses        914      874      -40     
+ Partials      257      252       -5
Files Changed Coverage Δ
status/reporters.go 62.37% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

dheerajodha
dheerajodha approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@dheerajodha dheerajodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hongweiliu17 hongweiliu17 merged commit fd8631a into konflux-ci:main Sep 11, 2023
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Sep 11, 2023
Merged
@hongweiliu17 hongweiliu17 deleted the update_PAC_ns branch October 11, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheerajodha dheerajodha dheerajodha approved these changes

@MartinBasti MartinBasti MartinBasti approved these changes

@14rcole 14rcole Awaiting requested review from 14rcole 14rcole is a code owner

@Josh-Everett Josh-Everett Awaiting requested review from Josh-Everett Josh-Everett is a code owner

@jinqi7 jinqi7 Awaiting requested review from jinqi7

@dirgim dirgim Awaiting requested review from dirgim dirgim is a code owner

@jsztuka jsztuka Awaiting requested review from jsztuka jsztuka is a code owner

@jencull jencull Awaiting requested review from jencull jencull is a code owner

Assignees

@MartinBasti MartinBasti

@dheerajodha dheerajodha

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hongweiliu17 @MartinBasti @dheerajodha