-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(STONEINTG-524): Report result of handling ITS to github in a new controller #296
Conversation
8e520c3
to
f882437
Compare
2ff989b
to
88fe5b0
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #296 +/- ##
==========================================
- Coverage 69.54% 67.95% -1.59%
==========================================
Files 38 40 +2
Lines 3658 4029 +371
==========================================
+ Hits 2544 2738 +194
- Misses 865 1006 +141
- Partials 249 285 +36
☔ View full report in Codecov by Sentry. |
ec97a2e
to
767d218
Compare
94f2140
to
265bf56
Compare
e8f809d
to
7cb755a
Compare
A feature branch |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
05cd934
to
04a0fb2
Compare
* Create function to get credential from snapshot * Create function to report for result of handle ITSes for snapshot * Add diagram for statusreport controller Signed-off-by: Hongwei Liu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work!
Thanks all for your review! |
Checkrun examples in github https://github.com/hongliuorg/devfile-sample-go-basic/pull/3/checks?check_run_id=16739942606
Maintainers will complete the following section