Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(STONEINTG-488): react to application component deletion #273

Merged
merged 1 commit into from
Oct 2, 2023
Merged

feat(STONEINTG-488): react to application component deletion #273

merged 1 commit into from
Oct 2, 2023

Conversation

Josh-Everett
Copy link
Contributor

@Josh-Everett Josh-Everett commented Aug 11, 2023 •
edited by dirgim
Loading

Creation of component controller to watch for component deletion events. When a component is deleted, IS will create a new snapshot to reflect those changes as well as update snapshotenvironmentbindings.

Maintainers will complete the following section

  • Commit messages are descriptive enough (hints)
  • Code coverage from testing does not decrease and new code is covered
  • Controllers diagrams are updated when PR changes controllers code (if applicable)

@openshift-ci
Copy link

openshift-ci bot commented Aug 11, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@Josh-Everett Josh-Everett force-pushed the 488 branch 2 times, most recently from be57b5e to b5c6eb3 Compare August 11, 2023 06:01
@Josh-Everett Josh-Everett changed the title feat(stoneintg-488): react to application component deletion feat(STONEINTG-488): react to application component deletion Aug 11, 2023
@dheerajodha dheerajodha requested a review from jencull August 11, 2023 06:32
@Josh-Everett Josh-Everett changed the title feat(STONEINTG-488): react to application component deletion wip(STONEINTG-488): react to application component deletion Aug 11, 2023
@Josh-Everett Josh-Everett force-pushed the 488 branch 2 times, most recently from 9b69cbf to 616b3af Compare September 6, 2023 07:15
@Josh-Everett Josh-Everett marked this pull request as ready for review September 8, 2023 18:59
@Josh-Everett Josh-Everett changed the title wip(STONEINTG-488): react to application component deletion feat(STONEINTG-488): react to application component deletion Sep 8, 2023
@Josh-Everett Josh-Everett force-pushed the 488 branch 2 times, most recently from 6461939 to 0967a8c Compare September 21, 2023 14:16
@dirgim
Copy link
Collaborator

dirgim commented Sep 21, 2023

@Josh-Everett can you create a simple diagram (guide) for the new controller?

@Josh-Everett
Copy link
Contributor Author

Diagram added here

@Josh-Everett Josh-Everett force-pushed the 488 branch 3 times, most recently from c7fe291 to a3ea2ee Compare September 26, 2023 03:30
@dirgim
Copy link
Collaborator

dirgim commented Sep 26, 2023

Running make manifests should resolve the current Check sources CI failure.

@Josh-Everett Josh-Everett force-pushed the 488 branch 2 times, most recently from 91db230 to 5b46ff8 Compare September 27, 2023 02:18
@14rcole 14rcole self-requested a review September 27, 2023 20:43
@openshift-ci openshift-ci bot added the lgtm label Sep 27, 2023
@Josh-Everett
feat(STONEINTG-488): react to application component deletion
d04180b 
Creation of component controller to watch for component deletion events.
When a component is deleted, IS will create a new snapshot to reflect
those changes.

Signed-off-by: Josh Everett <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Oct 2, 2023
dirgim
dirgim approved these changes Oct 2, 2023
View reviewed changes
Copy link
Collaborator

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openshift-ci openshift-ci bot added the lgtm label Oct 2, 2023
@Josh-Everett Josh-Everett merged commit aa00ca3 into konflux-ci:main Oct 2, 2023
9 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Oct 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dheerajodha dheerajodha dheerajodha left review comments

@hongweiliu17 hongweiliu17 hongweiliu17 left review comments

@dirgim dirgim dirgim approved these changes

@MartinBasti MartinBasti MartinBasti left review comments

@14rcole 14rcole 14rcole approved these changes

@jinqi7 jinqi7 Awaiting requested review from jinqi7

@jsztuka jsztuka Awaiting requested review from jsztuka jsztuka is a code owner

@jencull jencull Awaiting requested review from jencull jencull is a code owner

Assignees

@14rcole 14rcole

@dirgim dirgim

Labels
lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Josh-Everett @dirgim @14rcole @MartinBasti @hongweiliu17 @dheerajodha