Merge pull request #814 from jencull/stoneintg-924

fix(stoneintg-924): intermittent unittest failure missing application…
konflux-ci · Jul 23, 2024 · f53a4ba · f53a4ba
2 parents ba31546 + e07b878
commit f53a4ba
Showing 1 changed file with 9 additions and 0 deletions.
diff --git a/internal/controller/snapshot/snapshot_controller_test.go b/internal/controller/snapshot/snapshot_controller_test.go
@@ -198,6 +198,15 @@ var _ = Describe("SnapshotController", func() {
 		hasSnapshot.Spec.Application = string("im-a-ghost")
 		Expect(k8sClient.Update(ctx, hasSnapshot)).Should(Succeed())
 
+		// Use Eventually to ensure the update has been applied
+		Eventually(func() bool {
+			err := k8sClient.Get(ctx, types.NamespacedName{
+				Namespace: hasSnapshot.Namespace,
+				Name:      hasSnapshot.Name,
+			}, hasSnapshot)
+			return err == nil && hasSnapshot.Spec.Application == "im-a-ghost"
+		}, time.Second*20, time.Second*2).Should(BeTrue())
+
 		result, err := snapshotReconciler.Reconcile(ctx, req)
 		Expect(result).To(Equal(ctrl.Result{}))
 		Expect(err).To(BeNil())