fix: update some values in the data of RPA for FBC #1470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinqi7
force-pushed
the
fix_fbc_values
branch
from
c80b2e7 to
00b8fb3
Compare
johnbieren
reviewed
Dec 4, 2024
| @@ -341,16 +342,26 @@ func createFBCEnterpriseContractPolicy(fbcECPName string, managedFw framework.Fr | |||
|
|
|||
| func createFBCReleasePlanAdmission(fbcRPAName string, managedFw framework.Framework, devNamespace, managedNamespace, fbcAppName, fbcECPName, pathInRepoValue, hotfix, issueId, preGA, productName, productVersion, isStagedIndex string) { | |||
| var err error | |||
|
|
|||
| hotFix, err := strconv.ParseBool(hotfix) | |||
There was a problem hiding this comment.
Why not just change the function signature to have these be bools and then pass bools on line 89 and 138?
There was a problem hiding this comment.
OK. Changed to use bool type in the function definition. Thanks
jinqi7
force-pushed
the
fix_fbc_values
branch
2 times, most recently
from
a9a7b6b to
e774672
Compare
Signed-off-by: Jing Qi <[email protected]> Correct the type of some values in the data of RPA for FBC test case
jinqi7
force-pushed
the
fix_fbc_values
branch
from
e774672 to
8c1cf63
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnbieren The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
So this PR will run the fbc test as part of |
This was referenced Dec 4, 2024
arewm
added a commit
to arewm/build-definitions
that referenced
this pull request
Dec 4, 2024
Included PRs: - konflux-ci/e2e-tests#1469 - konflux-ci/e2e-tests#1451 - konflux-ci/e2e-tests#1460 - konflux-ci/e2e-tests#1470 Signed-off-by: arewm <[email protected]>
arewm
added a commit
to arewm/build-definitions
that referenced
this pull request
Dec 4, 2024
Included PRs: - konflux-ci/e2e-tests#1469 - konflux-ci/e2e-tests#1451 - konflux-ci/e2e-tests#1460 - konflux-ci/e2e-tests#1470 Signed-off-by: arewm <[email protected]>
github-merge-queue bot
pushed a commit
to konflux-ci/build-definitions
that referenced
this pull request
Dec 4, 2024
Included PRs: - konflux-ci/e2e-tests#1469 - konflux-ci/e2e-tests#1451 - konflux-ci/e2e-tests#1460 - konflux-ci/e2e-tests#1470 Signed-off-by: arewm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jing Qi [email protected]
Correct the type of some values in the data of RPA for FBC test case
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: