-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: remove SBOM test #1465
test: remove SBOM test #1465
Conversation
The SBOM focused test is no longer needed because the SBOM is no longer injected into the container image. This was removed in a separate PR in the buildah task. JIRA: ISV-5411 Signed-off-by: Ales Raszka <[email protected]>
/retest |
@Allda: The following test has Failed, say /retest to rerun failed tests.
Inspecting Test ArtifactsTo inspect your test artifacts, follow these steps:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/e2e-tests:konflux-e2e-ccdg9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's still one test that does basic SBOM checks (should ensure SBOM is shown ...
), so this LGTM
/lgtm |
But I was looking for a test that would check the SBOM that we upload to the registry using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO those tests that failed in the latest CI run are not related to this PR
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chmeliik, psturc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The SBOM focused test is no longer needed because the SBOM is no longer injected into the container image. This was removed in a separate PR in the buildah task.
JIRA: ISV-5411
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: