Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove SBOM test #1465

Merged
merged 1 commit into from
Nov 27, 2024
Merged

test: remove SBOM test #1465

merged 1 commit into from
Nov 27, 2024

Conversation

Allda
Copy link
Contributor

@Allda Allda commented Nov 26, 2024

The SBOM focused test is no longer needed because the SBOM is no longer injected into the container image. This was removed in a separate PR in the buildah task.

JIRA: ISV-5411

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

The SBOM focused test is no longer needed because the SBOM is no longer
injected into the container image. This was removed in a separate PR in
the buildah task.

JIRA: ISV-5411

Signed-off-by: Ales Raszka <[email protected]>
@Allda Allda changed the title Remove SBOM test test: remove SBOM test Nov 26, 2024
@Allda
Copy link
Contributor Author

Allda commented Nov 27, 2024

/retest

@konflux-ci-qe-bot
Copy link

@Allda: The following test has Failed, say /retest to rerun failed tests.

PipelineRun Name Status Rerun command Build Log Test Log
konflux-e2e-ccdg9 Failed /retest View Pipeline Log View Test Logs

Inspecting Test Artifacts

To inspect your test artifacts, follow these steps:

  1. Install ORAS (see the ORAS installation guide).
  2. Download artifacts with the following commands:
mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-test-storage/konflux-team/e2e-tests:konflux-e2e-ccdg9

@chmeliik chmeliik requested a review from tisutisu November 27, 2024 14:51
Copy link
Contributor

@chmeliik chmeliik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's still one test that does basic SBOM checks (should ensure SBOM is shown ...), so this LGTM

@chmeliik
Copy link
Contributor

/lgtm

@chmeliik
Copy link
Contributor

But I was looking for a test that would check the SBOM that we upload to the registry using cosign, and didn't find anything. @tisutisu did I just miss it? Should we file a story to add such a check?

Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO those tests that failed in the latest CI run are not related to this PR

Copy link

openshift-ci bot commented Nov 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chmeliik, psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psturc psturc merged commit 4e5e1cd into konflux-ci:main Nov 27, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants