Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(STONEINTG-1009): e2e tests for group snapshot #1461

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

jsztuka
Copy link
Contributor

@jsztuka jsztuka commented Nov 20, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Summary:

Adding a multirepo and single repo(multicomponent) scenarios for creation of group snapshot.

Upcoming changes post mortem

Reduce the triplication of component A, B and C into one for loop to reduce code amount.
Include gitLab repo for scenario of multiple repos having a group snapshot.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@jsztuka
Copy link
Contributor Author

jsztuka commented Nov 20, 2024

/retest

1 similar comment
@jsztuka
Copy link
Contributor Author

jsztuka commented Nov 20, 2024

/retest

Copy link
Contributor

@dirgim dirgim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsztuka
Copy link
Contributor Author

jsztuka commented Nov 20, 2024

/retest

@jsztuka
Copy link
Contributor Author

jsztuka commented Nov 20, 2024

/retest

1 similar comment
@hongweiliu17
Copy link
Contributor

/retest

Copy link
Contributor

@hongweiliu17 hongweiliu17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jsztuka
Copy link
Contributor Author

jsztuka commented Nov 21, 2024

/retest

@kasemAlem
Copy link
Contributor

@jsztuka , great job Kudos !

@kasemAlem
Copy link
Contributor

/lgtm

Copy link
Member

@dheerajodha dheerajodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!
/lgtm

Copy link

openshift-ci bot commented Nov 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dheerajodha, dirgim, hongweiliu17, Josh-Everett, kasemAlem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [dheerajodha,kasemAlem]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 14ef7bc into konflux-ci:main Nov 21, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants