Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Revert "skip multicomponent test with same git url" #1446

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mmorhun
Copy link
Contributor

@mmorhun mmorhun commented Nov 5, 2024

Reverts #1445 since the issue was fixed in konflux-ci/build-service#363

@mmorhun mmorhun requested review from psturc and tisutisu November 5, 2024 15:28
@mmorhun mmorhun self-assigned this Nov 5, 2024
@openshift-ci openshift-ci bot requested review from rcerven and tkdchen November 5, 2024 15:28
@mmorhun mmorhun changed the title Revert "chore: skip multicomponent test with same git url" chore: Revert "skip multicomponent test with same git url" Nov 5, 2024
Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Nov 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Nov 5, 2024
@psturc
Copy link
Member

psturc commented Nov 5, 2024

/retest

@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 5, 2024

/test konflux-e2e-tests-on-pull-request

Copy link

openshift-ci bot commented Nov 5, 2024

@mmorhun: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test load-test-ci-100u
  • /test load-test-ci-10u
  • /test load-test-ci-1u
  • /test load-test-ci-50u
  • /test load-test-ci-50u-realworld
  • /test load-test-max-concurrency-realworld
  • /test max-concurrency

The following commands are available to trigger optional jobs:

  • /test redhat-appstudio-e2e

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-konflux-ci-e2e-tests-main-images

In response to this:

/test konflux-e2e-tests-on-pull-request

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 6, 2024

/retest

2 similar comments
@tisutisu
Copy link
Contributor

tisutisu commented Nov 7, 2024

/retest

@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 11, 2024

/retest

@psturc
Copy link
Member

psturc commented Nov 11, 2024

it looks like that the test failure is related to this PR:

  build status annotation value: {"pac":{"state":"error","error-id":54,"error-message":"54: Git repository url isn't allowed"},"message":"done"}
  build status: &{State:error MergeUrl: ConfigurationTime: ErrorInfo:{ErrId:54 ErrMessage:54: Git repository url isn't allowed}}
  [FAILED] in [It] - /tmp/tmp.vnQwA0K477/tests/build/build.go:885 @ 11/11/24 12:15:23.547
  << Timeline

  [FAILED] Timed out after 120.000s.
  build status is unexpected
  Expected
      <bool>: false
  to be true
  In [It] at: /tmp/tmp.vnQwA0K477/tests/build/build.go:885 @ 11/11/24 12:15:23.547

full log:
https://app-artifact-browser.apps.rosa.konflux-qe.zmr9.p3.openshiftapps.com/e2e-tests/2024-11-11_12-23-54+konflux-e2e-wchfx/e2e-tests.log

@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 13, 2024

Build Service updated,
/test konflux-e2e

@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 13, 2024

/retest

@konflux-ci konflux-ci deleted a comment from openshift-ci bot Nov 13, 2024
@konflux-ci konflux-ci deleted a comment from openshift-ci bot Nov 13, 2024
@konflux-ci konflux-ci deleted a comment from openshift-ci bot Nov 13, 2024
@mmorhun
Copy link
Contributor Author

mmorhun commented Nov 13, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit a1645ce into main Nov 13, 2024
14 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the revert-1445-skip-mc branch November 13, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants