Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rm RP and RPA before creating in multiarch-advisories #1443

Closed
wants to merge 1 commit into from

Conversation

jinqi7
Copy link
Contributor

@jinqi7 jinqi7 commented Nov 2, 2024

Description

Because multiarch-advisories is using an existing application(not created in the test) for testing, all the test runs are use one application. We can't clean the RP/RPA/ECPolicy in the end in case affecting others. This PR is to clean up them before creating new ones.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Nov 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jinqi7. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jinqi7 jinqi7 force-pushed the clean_rpa_multiarch branch 3 times, most recently from 1bb7f52 to 76e1fb7 Compare November 2, 2024 08:40
@jinqi7 jinqi7 force-pushed the clean_rpa_multiarch branch from 76e1fb7 to 39f7fa8 Compare November 2, 2024 08:42
@jinqi7 jinqi7 changed the title fix: clean RP and RPA in multiarch-advisories fix: rm RP and RPA before creating in multiarch-advisories Nov 2, 2024
@jinqi7 jinqi7 marked this pull request as draft November 2, 2024 08:49
@jinqi7 jinqi7 closed this Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant