feat: enable dockerfile check for hermetic builds #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Skipping CI for Draft Pull Request. |
|
/test images |
STONEBLD-2795 Hermetic builds should now push the original dockerfile, not the modified one. Enable the check. Signed-off-by: Adam Cmiel <[email protected]>
chmeliik
force-pushed
the
dont-leave-dockerfile-modified
branch
from
2477cc9 to
48d560a
Compare
When the dockerfile image doesn't exist, print the expected image Compare the content of the Dockerfile as a string, not as an array of bytes. Otherwise the error message is not readable to humans. Signed-off-by: Adam Cmiel <[email protected]>
chmeliik
force-pushed
the
dont-leave-dockerfile-modified
branch
from
48d560a to
d73dae2
Compare
|
pairs with konflux-ci/build-definitions#1462 (that one should be merged first) |
mmorhun
approved these changes
Sep 27, 2024
tkdchen
approved these changes
Sep 27, 2024
|
/hold until the build-definitions counterpart is merged |
mkosiarc
approved these changes
Sep 27, 2024
|
/hold cancel |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkosiarc, mmorhun, tisutisu, tkdchen, tnevrlka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
STONEBLD-2795
Hermetic builds should now push the original dockerfile, not the modified one. Enable the check.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: