fix: remove simple build dependency from build and integration tests #1309
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| Expect(err).ShouldNot(HaveOccurred()) | ||
|
|
||
| for _, testScenario := range *integrationTestScenarios { | ||
| Expect(f.AsKubeAdmin.IntegrationController.DeleteIntegrationTestScenario(&testScenario, testNamespace)).To(Succeed()) |
Check failure
Code scanning / gosec
Implicit memory aliasing in for loop. Error test
There was a problem hiding this comment.
it was there in the code already, haven't changed it, I just copied here.
|
/test redhat-appstudio-e2e |
|
@tisutisu: The following test finished, in case test failed say /retest to rerun all failed tests:
To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute: mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-2vfrw-spts9For instructions on how to install ORAS, please refer to the ORAS installation guide. |
|
|
|
@tisutisu: The following test finished, in case test failed say /retest to rerun all failed tests:
To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute: mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-jgk7b-sk6fbFor instructions on how to install ORAS, please refer to the ORAS installation guide. |
|
@tisutisu: The following test finished, in case test failed say /retest to rerun all failed tests:
To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute: mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-dvvwt-j6mr7For instructions on how to install ORAS, please refer to the ORAS installation guide. |
|
/test redhat-appstudio-e2e |
|
@tisutisu: The following test finished, in case test failed say /retest to rerun all failed tests:
To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute: mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-x2s5z-gm6lzFor instructions on how to install ORAS, please refer to the ORAS installation guide. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jinqi7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
/hold |
| Expect(err).ShouldNot(HaveOccurred()) | ||
|
|
||
| for _, testScenario := range *integrationTestScenarios { | ||
| Expect(f.AsKubeAdmin.IntegrationController.DeleteIntegrationTestScenario(&testScenario, testNamespace)).To(Succeed()) |
|
Probably a conflict during execution /retest |
|
@tisutisu: The following test finished, in case test failed say /retest to rerun all failed tests:
To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute: mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-wcvx7-xwjv2For instructions on how to install ORAS, please refer to the ORAS installation guide. |
|
@tisutisu: The following test finished, in case test failed say /retest to rerun all failed tests:
To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute: mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-cmrp4-df762For instructions on how to install ORAS, please refer to the ORAS installation guide. |
/retest these failures make me think whether we should rather start creating unique repositories for PaC tests in ephemeral clusters instead of reusing a single repositoriy for multiple tests, which could lead to such conflicts 🤔 |
suspecting it is due to the parallel running e2e-tests in konflux CI (that we are trying to onboard) and e2e-tests running in openshift-ci. |
|
@tisutisu: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
@psturc: The following test finished, in case test failed say /retest to rerun all failed tests:
To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute: mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-7z84z-dss5mFor instructions on how to install ORAS, please refer to the ORAS installation guide. |
I think this could be happening even after we disable openshift-ci, i.e. in cases, when multiple jobs (across repositories) are running at the same time. IMO creation of unique test repository for each test could eliminate this problem. |
|
/test (this should trigger retest just in konflux-ci) |
|
@psturc: The
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@psturc: The following test finished, in case test failed say /retest to rerun all failed tests:
To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute: mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-tpfkr-jczxvFor instructions on how to install ORAS, please refer to the ORAS installation guide. |
|
@tisutisu: The following test finished, in case test failed say /retest to rerun all failed tests:
To inspect your test artifacts make sure you have installed ORAS in your local machine. To inspect all test artifacts execute: mkdir -p oras-artifacts
cd oras-artifacts
oras pull quay.io/konflux-qe-incubator/konflux-qe-oci-storage:konflux-e2e-pcn6d-dlgsxFor instructions on how to install ORAS, please refer to the ORAS installation guide. |
@psturc current conflict was in the test changes itself, fixed with this commit, I think conflict during parallel running needs to be addressed across all the suites, so created a story to address that, it would be good keep that enhancement in a separate story. Please take a look again, replied in the comments. |
|
/unhold |
Description
This PR includes changes to remove dependency on simple build usage from build and integration service related suites
Issue ticket number and link
https://issues.redhat.com/browse/STONEBLD-2611
Type of change
How Has This Been Tested?
Locally and build-definitions CI with this PR
Checklist: