Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check pushed Dockerfile #1257

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

tkdchen
Copy link
Contributor

@tkdchen tkdchen commented Jul 8, 2024

Description

Require konflux-ci/build-definitions#1129 to be merged.

Issue ticket number and link

STONEBLD-2522

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Jul 8, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

tests/build/build_templates.go Dismissed Show dismissed Hide dismissed
STONEBLD-2522

Signed-off-by: Chenxiong Qi <[email protected]>
@tkdchen tkdchen force-pushed the STONEBLD-2522-push-Dockerfile branch from c8e845a to 1cd9396 Compare August 8, 2024 01:29
@tkdchen tkdchen marked this pull request as ready for review August 8, 2024 01:29
@openshift-ci openshift-ci bot requested review from mmorhun and psturc August 8, 2024 01:30
@tkdchen
Copy link
Contributor Author

tkdchen commented Aug 8, 2024

/retest

@tkdchen
Copy link
Contributor Author

tkdchen commented Aug 8, 2024

/test konflux-e2e-tests

Copy link

openshift-ci bot commented Aug 8, 2024

@tkdchen: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test load-test-ci-100u
  • /test load-test-ci-10u
  • /test load-test-ci-1u
  • /test load-test-ci-50u
  • /test max-concurrency-advanced
  • /test max-concurrency-basic

The following commands are available to trigger optional jobs:

  • /test redhat-appstudio-e2e

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-konflux-ci-e2e-tests-main-images

In response to this:

/test konflux-e2e-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tkdchen
Copy link
Contributor Author

tkdchen commented Aug 8, 2024

/retest

@tkdchen tkdchen requested a review from tisutisu August 8, 2024 06:38
@tkdchen tkdchen requested a review from tisutisu August 9, 2024 02:53
@tisutisu
Copy link
Contributor

tisutisu commented Sep 9, 2024

/approve
/lgtm

Copy link

openshift-ci bot commented Sep 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tisutisu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 9, 2024
@tisutisu tisutisu merged commit 1577057 into konflux-ci:main Sep 9, 2024
13 checks passed
@tkdchen tkdchen deleted the STONEBLD-2522-push-Dockerfile branch September 9, 2024 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants