Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add token refreshing and refine the fbc test cases #1089

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

jinqi7
Copy link
Contributor

@jinqi7 jinqi7 commented Mar 20, 2024

Signed-off-by: Jing Qi [email protected]

The fbc test cases need to take several minutes for build pipelineRun and release pipelineRun. Since the access token expired sooner than before, the test cases
are refined and added the token refreshing during the test.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Signed-off-by: Jing Qi <[email protected]>

The fbc test cases need to take several minutes for build pipelineRun and release
pipelineRun. Since the access token expired sooner than before, the test cases
 are refined and added the token refreshing during the test.
@jinqi7 jinqi7 force-pushed the refresh_token branch 3 times, most recently from 002ca2a to a9382b0 Compare March 20, 2024 07:13
@jinqi7 jinqi7 requested review from psturc and johnbieren March 20, 2024 07:19
@jinqi7 jinqi7 changed the title fix: add token refreshing and refine the fbc test cases chore: add token refreshing and refine the fbc test cases Mar 20, 2024
Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few comments

magefiles/magefile.go Outdated Show resolved Hide resolved
tests/release/pipelines/fbc_release.go Outdated Show resolved Hide resolved
@psturc
Copy link
Member

psturc commented Mar 20, 2024

/approve

Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jinqi7
Copy link
Contributor Author

jinqi7 commented Mar 20, 2024

/retest

tests/release/pipelines/fbc_release.go Outdated Show resolved Hide resolved
tests/release/pipelines/fbc_release.go Outdated Show resolved Hide resolved
tests/release/pipelines/fbc_release.go Outdated Show resolved Hide resolved
tests/release/pipelines/fbc_release.go Show resolved Hide resolved
Signed-off-by: Jing Qi <[email protected]>

The fbc test cases need to take several minutes for build pipelineRun and release
pipelineRun. Since the access token expired sooner than before, the test cases
are refined and added the token refreshing during the test.
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@johnbieren
Copy link
Contributor

/lgtm

@jinqi7
Copy link
Contributor Author

jinqi7 commented Mar 20, 2024

/retest

1 similar comment
@jinqi7
Copy link
Contributor Author

jinqi7 commented Mar 20, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 1e8eefa into konflux-ci:main Mar 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants