Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove tests for deprecated SnapshotEnvironmentBinding controller #1088

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

mshaposhnik
Copy link
Contributor

Description

As the SEB controller is going to be deprecated and removed by SPI team (see https://issues.redhat.com/browse/SVPI-728), we need to cleanup tests which are testing it

Issue ticket number and link

https://issues.redhat.com/browse/SVPI-763

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from jsztuka and simonbaird March 19, 2024 13:10
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@mshaposhnik mshaposhnik changed the title chore: remove tests for deprecated SEB controller chore: remove tests for deprecated SnapshotEnvironmentBinding controller Mar 19, 2024
@mshaposhnik
Copy link
Contributor Author

/retest

4 similar comments
@mshaposhnik
Copy link
Contributor Author

/retest

@mshaposhnik
Copy link
Contributor Author

/retest

@mshaposhnik
Copy link
Contributor Author

/retest

@mshaposhnik
Copy link
Contributor Author

/retest

Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@dheerajodha dheerajodha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dheerajodha, psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Mar 20, 2024

🚨 Error occurred while running the E2E tests, list of failed Spec(s):

got error getting log 'build-e2e-ytnw-tenant/results/be1f188c-289e-48ac-bc9e-8e764f34178e/logs/97a490bb-acd0-3502-8a95-f872d0c9a5bb' for PipelineRun devfile-sample-python-basic-ujpr-vf7ss: failed to access Tekton Result Service with status code: 404 and
body: {"error":{"code":5,"message":"Log doesn't exist","details":[]}}

Unexpected error:
    <*errors.errorString | 0xc0016e0180>: 
    failed to access Tekton Result Service with status code: 404 and
    body: {"error":{"code":5,"message":"Log doesn't exist","details":[]}}
    
    {
        s: "failed to access Tekton Result Service with status code: 404 and\nbody: {\"error\":{\"code\":5,\"message\":\"Log doesn't exist\",\"details\":[]}}\n",
    }
occurred
  • ➡️ [failed] [It] [build-service-suite Build service E2E tests] test PaC component build when the PaC init branch is updated eventually leads to another update of a PR about the PipelineRun status report at Checks tab [build, HACBS, github-webhook, pac-build, pipeline, image-controller]
the initial PR 20968 in devfile-sample-hello-world repo doesn't contain the info about successful pipelinerun
Expected
    <string>: failure
to equal
    <string>: success

@mshaposhnik: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/redhat-appstudio-e2e 1312d23 link unknown /test redhat-appstudio-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mshaposhnik
Copy link
Contributor Author

/retest

@psturc
Copy link
Member

psturc commented Mar 20, 2024

the failures in the CI job are not related to changes in this PR

giving the fact that the e2e CI job already passed for this PR, I think it's ok to merge it

@psturc psturc merged commit b0c456e into konflux-ci:main Mar 20, 2024
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants