feat: Added tests for multi-platform dynamic IBM P&Z #1078
Conversation
|
/test e2e-on-pull-request |
|
@tisutisu: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| Expect(f.AsKubeAdmin.CommonController.DeleteSecret(ControllerNamespace, SshSecretName)).To(Succeed()) | ||
| Expect(f.AsKubeAdmin.CommonController.DeleteConfigMap(HostConfig, ControllerNamespace, true)).To(Succeed()) | ||
|
|
||
| //Forcefully remove instance incase it is not removed by multi-platform-controller |
tisutisu
force-pushed
the
multi-platform-ibm-tests
branch
from
58d2d0a to
0df8cc1
Compare
tests/build/multi-platform.go
Outdated
|
|
||
| }) | ||
| }) | ||
| Describe("ibmp dynamic allocation", Label("ibmp-dynamic"), func() { |
There was a problem hiding this comment.
Nitpick: use full spell "Power PC" instead of "p" so that it reflects the meaning straightforward.
There was a problem hiding this comment.
added in the describe section
tests/build/multi-platform.go
Outdated
| } | ||
|
|
||
| //sleep for 10 sec so that multi-platform-controller pod comes up | ||
| time.Sleep(10 * time.Second) |
There was a problem hiding this comment.
Any reason not use Eventually to wait for the pod comes up?
|
Are these tests only for dynamic provision or the whole process of a multi-arch build? |
| lastBundle.Value = *tektonapi.NewStructuredValues("quay.io/redhat-appstudio-tekton-catalog/task-buildah-remote:0.1") | ||
| lastName.Value = *tektonapi.NewStructuredValues("buildah-remote") | ||
| t.Params = append(t.Params, tektonapi.Param{Name: "PLATFORM", Value: *tektonapi.NewStructuredValues("$(params.PLATFORM)")}) | ||
| dockerPipelineObject.Spec.Params = append(dockerPipelineObject.PipelineSpec().Params, tektonapi.ParamSpec{Name: "PLATFORM", Default: tektonapi.NewStructuredValues(platformType)}) |
There was a problem hiding this comment.
I don't know how much it matters, but you would probably be better off just having a single pipeline adding a new pipeline level parameter.
There was a problem hiding this comment.
in that case the logic to create the bundle will be changed, but still we have to create 3 bundle and push them to quay separately for all the 3 architectures arm64, s30x and ppc64le.
There was a problem hiding this comment.
We don't, you just add a 'PLATFORM' param to the main pipeline, change this param to reference it, then pass it in in the tests. It's not a big deal either way.
|
|
||
| BeforeAll(func() { | ||
|
|
||
| f, err = framework.NewFramework(utils.GetGeneratedNamespace("multi-platform-ibmz")) |
There was a problem hiding this comment.
Other than the setup are all these tests pretty much the same? It seems like a lot of duplication here.
There was a problem hiding this comment.
let me try to reduce the duplicates.
There was a problem hiding this comment.
tried to reduce duplicates as much as possible. please have a look again.
@tkdchen the whole suite contains tests for |
tisutisu
force-pushed
the
multi-platform-ibm-tests
branch
from
f1a7142 to
3c88673
Compare
|
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mmorhun, stuartwdouglas, tisutisu, tkdchen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
This PR adds two tests related to dynamic allocation in IBM P&Z platforms
Issue ticket number and link
https://issues.redhat.com/browse/STONEBLD-1859
https://issues.redhat.com/browse/STONEBLD-1858
Type of change
How Has This Been Tested?
locally with
ginkgo --label-filter="multi-platform" --v ./cmdChecklist: