Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(load-test): fix max concurrency collect results script, add tekton result watcher metrics #1074

Conversation

pmacik
Copy link
Collaborator

@pmacik pmacik commented Mar 12, 2024

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from psturc and rhopp March 12, 2024 12:09
@pmacik
Copy link
Collaborator Author

pmacik commented Mar 12, 2024

/test ?

Copy link

openshift-ci bot commented Mar 12, 2024

@pmacik: The following commands are available to trigger required jobs:

  • /test images
  • /test load-test-ci-100u-1t
  • /test load-test-ci-10u-10t
  • /test load-test-ci-10u-10t-go
  • /test load-test-ci-10u-10t-java
  • /test load-test-ci-10u-10t-nodejs
  • /test load-test-ci-10u-10t-python
  • /test load-test-ci-10u-10t-quarkus
  • /test load-test-ci-1u-100t
  • /test load-test-ci-20u-5t
  • /test load-test-ci-2u-50t
  • /test load-test-ci-50u-2t
  • /test load-test-ci-5u-20t
  • /test load-test-ci-max-concurrency-basic-tekton-tuned
  • /test load-test-ci-poc
  • /test load-test-ci-tekton-tuning-base
  • /test load-test-ci-tekton-tuning-tuned
  • /test max-concurrency-advanced
  • /test max-concurrency-basic
  • /test redhat-appstudio-e2e

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-redhat-appstudio-e2e-tests-main-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmacik
Copy link
Collaborator Author

pmacik commented Mar 12, 2024

/test max-concurrency-basic

@pmacik
Copy link
Collaborator Author

pmacik commented Mar 12, 2024

/hold

@pmacik pmacik force-pushed the fix/max-concurrency-collect-results branch from 3bfbcf6 to aac042f Compare March 12, 2024 19:59
@pmacik
Copy link
Collaborator Author

pmacik commented Mar 12, 2024

/test max-concurrency-basic

@pmacik
Copy link
Collaborator Author

pmacik commented Mar 13, 2024

/unhold

@pmacik
Copy link
Collaborator Author

pmacik commented Mar 13, 2024

/assign @jhutar @naftalysh PTAL

Copy link

openshift-ci bot commented Mar 13, 2024

@pmacik: GitHub didn't allow me to assign the following users: PTAL.

Note that only redhat-appstudio members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @jhutar @naftalysh PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmacik pmacik force-pushed the fix/max-concurrency-collect-results branch from aac042f to cd927d9 Compare March 18, 2024 10:15
@pmacik
Copy link
Collaborator Author

pmacik commented Mar 18, 2024

/test max-concurrency-basic

@pmacik pmacik changed the title fix(load-test): fix max concurrency collect results script fix(load-test): fix max concurrency collect results script, add tekton result watcher metrics Mar 18, 2024
@pmacik pmacik force-pushed the fix/max-concurrency-collect-results branch from cd927d9 to fffd6f9 Compare March 18, 2024 10:24
@pmacik
Copy link
Collaborator Author

pmacik commented Mar 18, 2024

/test max-concurrency-basic

Copy link
Collaborator

@jhutar jhutar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 18, 2024
@pmacik
Copy link
Collaborator Author

pmacik commented Mar 18, 2024

/retest

1 similar comment
@pmacik
Copy link
Collaborator Author

pmacik commented Mar 18, 2024

/retest

Copy link

openshift-ci bot commented Mar 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jhutar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmacik
Copy link
Collaborator Author

pmacik commented Mar 18, 2024

/retest

3 similar comments
@pmacik
Copy link
Collaborator Author

pmacik commented Mar 19, 2024

/retest

@pmacik
Copy link
Collaborator Author

pmacik commented Mar 19, 2024

/retest

@pmacik
Copy link
Collaborator Author

pmacik commented Mar 20, 2024

/retest

@pmacik pmacik force-pushed the fix/max-concurrency-collect-results branch from fffd6f9 to 7fb61eb Compare March 20, 2024 10:43
@openshift-ci openshift-ci bot removed the lgtm label Mar 20, 2024
Copy link

openshift-ci bot commented Mar 20, 2024

New changes are detected. LGTM label has been removed.

@pmacik pmacik added lgtm and removed 1-5 min labels Mar 20, 2024
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pmacik
Copy link
Collaborator Author

pmacik commented Mar 22, 2024

/retest

@openshift-merge-bot openshift-merge-bot bot merged commit 7b6309f into konflux-ci:main Mar 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants