fix: The clair-scan task is not required for FBC pipelines #1065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In release-engineering/rhtap-ec-policy#19, I removed the requirement of multiple checks for FBC pipelines due to their special nature where the images produced are not themsleves pushed, instead metadata is extracted from it and published to the index for OLM. Therefore, we no longer need to require clair-scan images to be present for these pipelines either. Signed-off-by: arewm <[email protected]>
|
arewm
changed the title
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tisutisu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
arewm
added a commit
to arewm/build-definitions
that referenced
this pull request
Mar 8, 2024
This is follow-on work from the following PRs: release-engineering/rhtap-ec-policy#19 konflux-ci/e2e-tests#1065 Signed-off-by: arewm <[email protected]>
arewm
added a commit
to arewm/build-definitions
that referenced
this pull request
Mar 8, 2024
This is follow-on work from the following PRs: - release-engineering/rhtap-ec-policy#19 - konflux-ci/e2e-tests#1065 Signed-off-by: arewm <[email protected]>
mmorhun
pushed a commit
to konflux-ci/build-definitions
that referenced
this pull request
Mar 27, 2024
This is follow-on work from the following PRs: - release-engineering/rhtap-ec-policy#19 - konflux-ci/e2e-tests#1065 Signed-off-by: arewm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In release-engineering/rhtap-ec-policy#19, I removed the requirement of multiple checks for FBC pipelines due to their special nature where the images produced are not themsleves pushed, instead metadata is extracted from it and published to the index for OLM.
Therefore, we no longer need to require clair-scan images to be present for these pipelines either.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: