Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show-summary task check #1063

Merged

Conversation

tisutisu
Copy link
Contributor

@tisutisu tisutisu commented Mar 4, 2024

Description

Recently this change in build-definitions broke the fbc builds, failure was not detected by the tests. This check will ensure avoid repetitions of the same.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from chmeliik and rcerven March 4, 2024 08:14
@tisutisu tisutisu requested review from mmorhun, tkdchen and mkosiarc March 4, 2024 08:28
@tisutisu
Copy link
Contributor Author

tisutisu commented Mar 4, 2024

/test redhat-appstudio-e2e

@openshift-ci openshift-ci bot added the approved label Mar 4, 2024
@mmorhun
Copy link
Contributor

mmorhun commented Mar 4, 2024

/lgtm

@tisutisu
Copy link
Contributor Author

tisutisu commented Mar 5, 2024

Known issue
/test redhat-appstudio-e2e

Copy link

openshift-ci bot commented Mar 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasemAlem, mmorhun, tkdchen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tisutisu tisutisu force-pushed the check-show-summary-task branch from 0c157c3 to a7b8cab Compare March 6, 2024 08:45
@openshift-ci openshift-ci bot removed the lgtm label Mar 6, 2024
Copy link

sonarqubecloud bot commented Mar 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
1.5% Duplication on New Code

See analysis details on SonarCloud

@tkdchen
Copy link
Contributor

tkdchen commented Mar 6, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 6, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 086ef13 into konflux-ci:main Mar 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants