Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Retry removing finalizer from pipelineruns #1061

Merged

Conversation

tisutisu
Copy link
Contributor

Description

When pipelineRuns, err := kubeadminClient.HasController.GetAllPipelineRunsForApplication(applicationName, testNamespace) returns an error, we might leak the finalizers and removing finalizer will be skipped.
Added retry mechanism to try it multiple times.

Issue ticket number and link

https://issues.redhat.com/browse/KFLUXBUGS-1133

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a few suggestions otherwise lgtm

tests/build/build_templates.go Outdated Show resolved Hide resolved
tests/build/build_templates.go Outdated Show resolved Hide resolved
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@psturc psturc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasemAlem, psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@psturc
Copy link
Member

psturc commented Feb 29, 2024

known issue
/retest-required

@psturc
Copy link
Member

psturc commented Feb 29, 2024

KFLUXBUGS-1135
/retest-required

@psturc
Copy link
Member

psturc commented Mar 1, 2024

/retest-required

@openshift-merge-bot openshift-merge-bot bot merged commit d11a2af into konflux-ci:main Mar 1, 2024
13 checks passed
siddardh-ra pushed a commit to siddardh-ra/e2e-tests that referenced this pull request Mar 4, 2024
* Retry removing finalizer from pipelineruns

* Update tests/build/build_templates.go

Co-authored-by: Pavel Sturc <[email protected]>

* Update tests/build/build_templates.go

Co-authored-by: Pavel Sturc <[email protected]>

---------

Co-authored-by: Pavel Sturc <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants