-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Retry removing finalizer from pipelineruns #1061
fix: Retry removing finalizer from pipelineruns #1061
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a few suggestions otherwise lgtm
Co-authored-by: Pavel Sturc <[email protected]>
Co-authored-by: Pavel Sturc <[email protected]>
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kasemAlem, psturc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
known issue |
KFLUXBUGS-1135 |
/retest-required |
* Retry removing finalizer from pipelineruns * Update tests/build/build_templates.go Co-authored-by: Pavel Sturc <[email protected]> * Update tests/build/build_templates.go Co-authored-by: Pavel Sturc <[email protected]> --------- Co-authored-by: Pavel Sturc <[email protected]>
Description
When
pipelineRuns, err := kubeadminClient.HasController.GetAllPipelineRunsForApplication(applicationName, testNamespace)
returns an error, we might leak the finalizers and removing finalizer will be skipped.Added retry mechanism to try it multiple times.
Issue ticket number and link
https://issues.redhat.com/browse/KFLUXBUGS-1133
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: