Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: increase timeout for invalid annotation test #1060

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

psturc
Copy link
Member

@psturc psturc commented Feb 28, 2024

Description

this test fails from time to time due to insufficient timeout

this PR increases doubles the timeout and improves logging

Issue ticket number and link

KFLUXBUGS-101

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

ginkgo -v --label-filter='annotations' ./cmd/

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kasemAlem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kasemAlem
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Feb 28, 2024

🚨 Error occurred while running the E2E tests, list of failed Spec(s):

  • ➡️ [failed] [It] [rhtap-demo-suite] Maven project - Simple and Advanced build RHTAP Advanced build test for rhtap-demo-component when Component is switched to Advanced Build mode triggers creation of a PR in the sample repo [rhtap-demo]
Expected success, but got an error:
    <context.deadlineExceededError>: 
    context deadline exceeded
    {}

@psturc: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/redhat-appstudio-e2e 3a381e2 link unknown /test redhat-appstudio-e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@psturc
Copy link
Member Author

psturc commented Feb 28, 2024

failed on unrelated (and known) issue: https://issues.redhat.com/browse/KFLUXBUGS-580
merging

@psturc psturc merged commit 3b42977 into konflux-ci:main Feb 28, 2024
12 of 14 checks passed
@psturc psturc deleted the KFLUXBUGS-101 branch February 28, 2024 15:16
siddardh-ra pushed a commit to siddardh-ra/e2e-tests that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants