Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kfluxbugs-1128): fix rhtap-demo falkiness #1058

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

kasemAlem
Copy link
Contributor

@kasemAlem kasemAlem commented Feb 28, 2024

Description

fix test bug in rhtap-demo suite on ITS snapshot check

KFLUXBUGS-1128

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Feb 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kasemAlem
Copy link
Contributor Author

/test all

@kasemAlem
Copy link
Contributor Author

/test all

@kasemAlem kasemAlem force-pushed the KFLUXBUGS-1128 branch 2 times, most recently from c238f52 to 0d95cf3 Compare March 3, 2024 05:45
@kasemAlem kasemAlem marked this pull request as ready for review March 3, 2024 05:51
@openshift-ci openshift-ci bot requested review from jsztuka and mmorhun March 3, 2024 05:51
Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@kasemAlem kasemAlem requested a review from dheerajodha March 4, 2024 11:29
Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dheerajodha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 4, 2024
@kasemAlem kasemAlem requested a review from tisutisu March 4, 2024 11:53
@tisutisu
Copy link
Contributor

tisutisu commented Mar 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 4, 2024
@tisutisu tisutisu merged commit 8c8b8ac into konflux-ci:main Mar 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants