Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(RHTAPREL-852): don't run fbc tests in catalog PRs #1053

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

johnbieren
Copy link
Contributor

The fbc tests go against the stage cluster so they shouldn't be run on paired catalog PRs.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

The fbc tests go against the stage cluster so they shouldn't be run on
paired catalog PRs.

Signed-off-by: Johnny Bieren <[email protected]>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jinqi7
Copy link
Contributor

jinqi7 commented Feb 22, 2024

/lgtm
/approve

Copy link

openshift-ci bot commented Feb 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: happybhati, jinqi7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e

1 similar comment
@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e

@openshift-merge-bot openshift-merge-bot bot merged commit 21db9eb into konflux-ci:main Feb 23, 2024
13 checks passed
@johnbieren johnbieren deleted the rhtaprel_852 branch February 23, 2024 03:22
siddardh-ra pushed a commit to siddardh-ra/e2e-tests that referenced this pull request Mar 4, 2024
…i#1053)

The fbc tests go against the stage cluster so they shouldn't be run on
paired catalog PRs.

Signed-off-by: Johnny Bieren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants