fix: image digest check may meet race condition #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisutisu
reviewed
Feb 21, 2024
johnbieren
reviewed
Feb 21, 2024
johnbieren
reviewed
Feb 21, 2024
scoheb
reviewed
Feb 21, 2024
| imageDigest, err := releasecommon.GetDigestWithTagInQuay(releasecommon.ReleasedImagePushRepo + ":latest") | ||
| Expect(err).ShouldNot(HaveOccurred(), fmt.Sprintf("failed while getting Digest for quay image %s with error: %+v", releasecommon.ReleasedImagePushRepo + ":latest", err)) | ||
| Expect(imageDigest).To(Equal(containerImageDigest)) | ||
| tagExist, err := releasecommon.DoesTagExistsInQuay(releasecommon.ReleasedImagePushRepo + ":" + imageDigest) |
There was a problem hiding this comment.
are you really looking for a tag? you just want to see if the digest is there.
There was a problem hiding this comment.
Changed to check digest. Thanks
jinqi7
force-pushed
the
fix_sha_check
branch
from
4d5415d to
123cb3f
Compare
jinqi7
commented
Feb 21, 2024
magefiles/magefile.go
Outdated
| @@ -294,7 +294,7 @@ func (ci CI) TestE2E() error { | |||
| } | |||
|
|
|||
| func RunE2ETests() error { | |||
| labelFilter := utils.GetEnv("E2E_TEST_SUITE_LABEL", "!upgrade-create && !upgrade-verify && !upgrade-cleanup && !release-pipelines") | |||
There was a problem hiding this comment.
It's for testing and will be restored.
jinqi7
force-pushed
the
fix_sha_check
branch
from
123cb3f to
cea4a5d
Compare
jinqi7
force-pushed
the
fix_sha_check
branch
2 times, most recently
from
01e1640 to
be3e7ab
Compare
jinqi7
force-pushed
the
fix_sha_check
branch
3 times, most recently
from
7d8fb58 to
f7a14ab
Compare
|
/retest |
jinqi7
force-pushed
the
fix_sha_check
branch
7 times, most recently
from
4ffdeba to
f81b828
Compare
johnbieren
approved these changes
Feb 22, 2024
jinqi7
force-pushed
the
fix_sha_check
branch
4 times, most recently
from
181d07d to
952fcf5
Compare
jinqi7
force-pushed
the
fix_sha_check
branch
4 times, most recently
from
7128767 to
7d499fa
Compare
jinqi7
force-pushed
the
fix_sha_check
branch
from
7d499fa to
61e445d
Compare
|
/retest |
2 similar comments
|
/retest |
|
/retest |
jinqi7
force-pushed
the
fix_sha_check
branch
from
61e445d to
4c92ccd
Compare
happybhati
approved these changes
Feb 26, 2024
|
/lgtm |
Signed-off-by: Jing Qi <[email protected]>
jinqi7
force-pushed
the
fix_sha_check
branch
from
4c92ccd to
097f3fc
Compare
|
happybhati
approved these changes
Feb 26, 2024
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: happybhati, jinqi7, johnbieren The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
siddardh-ra
pushed a commit
to siddardh-ra/e2e-tests
that referenced
this pull request
Mar 4, 2024
Signed-off-by: Jing Qi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
Issue ticket number and link
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: