Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(RHTAPREL-371): don't create rolebinding in release tests #1050

Merged
merged 1 commit into from
Feb 27, 2024
Merged

refactor(RHTAPREL-371): don't create rolebinding in release tests #1050

merged 1 commit into from
Feb 27, 2024

Conversation

johnbieren
Copy link
Contributor

The RoleBinding granting access to the release-pipeline-resource-role in the dev namespace is now created by the Release controller so no longer has to be created manaully in the Release tests.

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Issue ticket number and link

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@johnbieren
Copy link
Contributor Author

Depends on konflux-ci/release-service#374
I intentionally didn't pair them because I want to see the CI run fail here before konflux-ci/release-service#374 is merged, then pass once it does merge

@johnbieren
Copy link
Contributor Author

/test all

@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e
failed build pipelinerun

@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e

1 similar comment
@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e

@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e

@johnbieren
Copy link
Contributor Author

konflux-ci/release-service#374 merged, this should pass now

@johnbieren johnbieren marked this pull request as ready for review February 22, 2024 19:54
@openshift-ci openshift-ci bot requested a review from scoheb February 22, 2024 19:54
@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e

3 similar comments
@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e

@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e

@johnbieren
Copy link
Contributor Author

/test redhat-appstudio-e2e

@jinqi7
Copy link
Contributor

jinqi7 commented Feb 23, 2024

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Feb 23, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Feb 23, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jinqi7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jinqi7
Copy link
Contributor

jinqi7 commented Feb 23, 2024 •
edited
Loading

/hold

The PR can't be merged until the PR in release-service is merged

@johnbieren
refactor(RHTAPREL-371): don't create rolebinding in release tests
6075e67 
The RoleBinding granting access to the release-pipeline-resource-role in
the dev namespace is now created by the Release controller so no longer
has to be created manaully in the Release tests.

Signed-off-by: Johnny Bieren <[email protected]>
@openshift-ci openshift-ci bot removed the lgtm label Feb 26, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@johnbieren
Copy link
Contributor Author

/hold

The PR can't be merged until the PR in release-service is merged

This depended on konflux-ci/release-service#374, not 367

@johnbieren
Copy link
Contributor Author

/retest-required

@johnbieren
Copy link
Contributor Author

/unhold

@jinqi7
Copy link
Contributor

jinqi7 commented Feb 27, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Feb 27, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 466894c into konflux-ci:main Feb 27, 2024
13 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Feb 27, 2024
Merged
@johnbieren johnbieren deleted the rolebinding branch February 27, 2024 12:02
siddardh-ra pushed a commit to siddardh-ra/e2e-tests that referenced this pull request Mar 4, 2024
@johnbieren
refactor(RHTAPREL-371): don't create rolebinding in release tests (ko…
970705b 
…nflux-ci#1050)

The RoleBinding granting access to the release-pipeline-resource-role in
the dev namespace is now created by the Release controller so no longer
has to be created manaully in the Release tests.

Signed-off-by: Johnny Bieren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theflockers theflockers Awaiting requested review from theflockers

@davidmogar davidmogar Awaiting requested review from davidmogar

@mmalina mmalina Awaiting requested review from mmalina

@jinqi7 jinqi7 Awaiting requested review from jinqi7

@happybhati happybhati Awaiting requested review from happybhati

@scoheb scoheb Awaiting requested review from scoheb

Assignees

@jinqi7 jinqi7

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnbieren @jinqi7 @openshift-merge-robot