Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add team specific template generation #1048

Merged
merged 8 commits into from
Mar 4, 2024

Conversation

tnevrlka
Copy link
Contributor

@tnevrlka tnevrlka commented Feb 20, 2024

Description

Allow teams to generate a Ginkgo spec from outline using their team
specific templates.
Please see the docs/DeveloperGenerateTest.md for more information

Issue ticket number and link

KONFLUX-2212 (part of KONFLUX-434 epic)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Work on tests can be tracked as part of KONFLUX-2061.
New function is covered by a unit test.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Feb 20, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@tnevrlka tnevrlka changed the title feat: add team specific template generation feat: add team specific template generation Feb 20, 2024
@tnevrlka tnevrlka marked this pull request as ready for review February 26, 2024 15:47
@openshift-ci openshift-ci bot requested review from pmacik and scoheb February 26, 2024 15:47
@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka requested a review from Dannyb48 March 1, 2024 14:38
Copy link
Contributor

@Dannyb48 Dannyb48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say keep the recommended one and we can delete the barebones one.

Copy link

sonarqubecloud bot commented Mar 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tnevrlka
Copy link
Contributor Author

tnevrlka commented Mar 4, 2024

I would say keep the recommended one and we can delete the barebones one.

Done

@tnevrlka tnevrlka requested a review from Dannyb48 March 4, 2024 14:52
Copy link
Contributor

@Dannyb48 Dannyb48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

openshift-ci bot commented Mar 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Dannyb48

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Mar 4, 2024
@Dannyb48
Copy link
Contributor

Dannyb48 commented Mar 4, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dc55fcf into konflux-ci:main Mar 4, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants