Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rp-preproc cleanup #1023

Merged

Conversation

tnevrlka
Copy link
Contributor

@tnevrlka tnevrlka commented Jan 30, 2024

Description

CustomJUnitReporter is no longer used and was moved to https://github.com/redhat-appstudio/qe-tools/
rp_preproc got replaced by droute

This PR aims to cleanup code previously used for Report Portal reporting that is no longer used

Issue ticket number and link

KONFLUX-797
KONFLUX-784

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally by make local/test/e2e.
Should be also tested here by CI and looking afterwards if the upload to Report Portal is successful.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

@openshift-ci openshift-ci bot requested review from 14rcole and scoheb January 30, 2024 13:47
@tnevrlka
Copy link
Contributor Author

/hold

@tnevrlka
Copy link
Contributor Author

/retest

@tnevrlka tnevrlka force-pushed the report-portal-cleanup branch from c3a68ad to 514d76f Compare January 31, 2024 16:12
@tnevrlka
Copy link
Contributor Author

/retest

@Dannyb48
Copy link
Contributor

Dannyb48 commented Feb 5, 2024

@tnevrlka are we good? What is left to drive this forward?

@tnevrlka
Copy link
Contributor Author

tnevrlka commented Feb 6, 2024

@Dannyb48 There might be changes required due to KFLUXBUGS-16. It's in a Slack thread, but the gist is that something like CustomJUnitReporter might be needed in order to have correct timestamps for all the testcases

@tnevrlka tnevrlka closed this Feb 16, 2024
@tnevrlka tnevrlka deleted the report-portal-cleanup branch February 16, 2024 16:42
@tnevrlka tnevrlka restored the report-portal-cleanup branch February 16, 2024 17:21
@tnevrlka tnevrlka reopened this Feb 16, 2024
@tnevrlka tnevrlka force-pushed the report-portal-cleanup branch from 514d76f to f500f7f Compare February 29, 2024 14:25
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

openshift-ci bot commented Mar 8, 2024

@tnevrlka: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/load-test-max-concurrency-basic f500f7f link true /test load-test-max-concurrency-basic
ci/prow/load-test-max-concurrency-advanced f500f7f link true /test load-test-max-concurrency-advanced
ci/prow/load-test-ci-daily-10u-10t f500f7f link true /test load-test-ci-daily-10u-10t

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@tnevrlka tnevrlka force-pushed the report-portal-cleanup branch from f500f7f to f4d48e1 Compare April 3, 2024 14:29
Copy link

sonarqubecloud bot commented Apr 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@psturc
Copy link
Member

psturc commented Apr 4, 2024

/unhold
/lgtm
/approve

Copy link

openshift-ci bot commented Apr 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: psturc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Apr 4, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 8a6b8e8 into konflux-ci:main Apr 4, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants