Skip to content

Commit

Permalink
fix: git repo url should have .git suffix
Browse files Browse the repository at this point in the history
This url is used in the RPA and it's used for Tekton
git resolver. All the RPAs in konflux-release-data repo
use the .git suffix and it's also what's used
as an example in Tekton docs.

For context, a user recently hit an issue:
konflux-ci/release-service-catalog#759

We had a bug that caused an issue with the .git suffix. But e2e
didn't expose the problem because the .git suffix was not there.

Signed-off-by: Martin Malina <[email protected]>
  • Loading branch information
mmalina committed Dec 20, 2024
1 parent 20c1bfc commit ed4a4d5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/constants/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ const (
GITLAB_PROJECT_ID_ENV string = "GITLAB_PROJECT_ID"

// Release service catalog default URL and revision for e2e tests
RELEASE_CATALOG_DEFAULT_URL = "https://github.com/konflux-ci/release-service-catalog"
RELEASE_CATALOG_DEFAULT_URL = "https://github.com/konflux-ci/release-service-catalog.git"
RELEASE_CATALOG_DEFAULT_REVISION = "staging"

// Test namespace's required labels
Expand Down

0 comments on commit ed4a4d5

Please sign in to comment.