Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nudging works for private image repositories #356

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Nudging works for private image repositories #356

merged 4 commits into from
Oct 10, 2024

Conversation

rcerven
Copy link
Contributor

@rcerven rcerven commented Oct 8, 2024

Checklist:

  • PR has reference to the issue(s) it resolves
  • Write / update unit tests
  • Write / update integration (envtest) tests
  • Ensure there is an issue for e2e tests if needed
  • Ensure make test passes
  • Ensure test coverage hasn't decreased
  • Test code changes manually
  • Update readme and documentation
  • Write PR description that highlights overall changes and add usage examples if applicable

rcerven added 3 commits October 8, 2024 18:24
@rcerven
Ensure pipeline service account before waiting for updated
ecfb95d 
ContainerImage, that way image-controller will be able to eventually
find it and link push secret to it

Signed-off-by: Robert Cerven <[email protected]>
@rcerven
Setting no limits for hourly and concurrent renovate PRs
692fdc4 
KFLUXBUGS-1691

Signed-off-by: Robert Cerven <[email protected]>
@rcerven
When nudged component doesn't exist exit sooner
4431762 
Signed-off-by: Robert Cerven <[email protected]>
@rcerven rcerven changed the title [WIP] Privatenudging [WIP] Nudging works for private image repositories Oct 8, 2024
@rcerven rcerven mentioned this pull request Oct 8, 2024
Merged
@rcerven rcerven force-pushed the privatenudging branch 2 times, most recently from 8be952a to c5ef20c Compare October 9, 2024 21:32
@rcerven rcerven changed the title [WIP] Nudging works for private image repositories Nudging works for private image repositories Oct 9, 2024
@rcerven
Nudging now works for private image repositories
7fdec5a 
KFLUXBUGS-1609

Signed-off-by: Robert Cerven <[email protected]>
@rcerven
Copy link
Contributor Author

rcerven commented Oct 10, 2024

/retest

@rcerven rcerven merged commit bb5d480 into konflux-ci:main Oct 10, 2024
9 checks passed
@rh-tap-build-team rh-tap-build-team bot mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorhun mmorhun mmorhun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rcerven @mmorhun