Add predicate

controllers/component_dependency_update_controller.go

@@ -26,8 +26,10 @@ import (
 	"k8s.io/client-go/tools/record"
 	"knative.dev/pkg/apis"
 	ctrl "sigs.k8s.io/controller-runtime"
+	"sigs.k8s.io/controller-runtime/pkg/builder"
 	"sigs.k8s.io/controller-runtime/pkg/client"
 	"sigs.k8s.io/controller-runtime/pkg/controller/controllerutil"
+	"sigs.k8s.io/controller-runtime/pkg/event"
 	ctrllog "sigs.k8s.io/controller-runtime/pkg/log"
 	"sigs.k8s.io/controller-runtime/pkg/predicate"
 	"sigs.k8s.io/controller-runtime/pkg/reconcile"
@@ -87,8 +89,37 @@ func (r *ComponentDependencyUpdateReconciler) SetupWithManager(manager ctrl.Mana
 // out pipelines we don't need
 func setupControllerWithManager(manager ctrl.Manager, reconciler *ComponentDependencyUpdateReconciler) error {
 	return ctrl.NewControllerManagedBy(manager).
-		For(&tektonapi.PipelineRun{}).
-		WithEventFilter(predicate.NewPredicateFuncs(IsBuildPushPipelineRun)).
+		For(&tektonapi.PipelineRun{}, builder.WithPredicates(predicate.Funcs{
+			CreateFunc: func(e event.CreateEvent) bool {
+				return true
+			},
+			UpdateFunc: func(e event.UpdateEvent) bool {
+				new, ok := e.ObjectNew.(*tektonapi.PipelineRun)
+				if !ok {
+					return false
+				}
+				if !IsBuildPushPipelineRun(new) {
+					return false
+				}
+
+				// Ensure we have not finished processing
+				if new.ObjectMeta.Labels != nil && new.ObjectMeta.Labels[NudgeProcessedAnnotationName] != "" {
+					return false
+				}
+
+				if new.Status.CompletionTime == nil || new.Status.CompletionTime.IsZero() {
+					// Pipeline run is still in progress, only return true if we need to add the finalizer
+					return !controllerutil.ContainsFinalizer(new, NudgeFinalizer)
+				}
+				return true
+			},
+			DeleteFunc: func(e event.DeleteEvent) bool {
+				return controllerutil.ContainsFinalizer(e.Object, NudgeFinalizer)
+			},
+			GenericFunc: func(e event.GenericEvent) bool {
+				return false
+			},
+		})).
 		Complete(reconciler)
 }
 
@@ -295,6 +326,12 @@ func (r *ComponentDependencyUpdateReconciler) removePipelineFinalizer(ctx contex
 
 func IsBuildPushPipelineRun(object client.Object) bool {
 	if pipelineRun, ok := object.(*tektonapi.PipelineRun); ok {
+
+		// Ensure the PipelineRun belongs to a Component
+		if pipelineRun.Labels == nil || pipelineRun.Labels[ComponentNameLabelName] == "" {
+			// PipelineRun does not belong to a Component
+			return false
+		}
 		if pipelineRun.Labels != nil && pipelineRun.Annotations != nil {
 			if pipelineRun.Labels[PipelineRunTypeLabelName] == PipelineRunBuildType && pipelineRun.Annotations[PacEventTypeLabelName] == PacEventPushType {
 				return true