e2e-tests update

[rh-tap-build-team]

Included PRs:

• fix(EC-619): Set default for tekton bundle repo e2e-tests#1151
• chore(DEVHAS-648): Remove GitOps repository related test code e2e-tests#1145
• fix(EC-624): tkn-bundle bug fixes e2e-tests#1157
• fix: Use golden-container latest images in enterprise contract tests e2e-tests#1156
• fix: skip tkn-bundle task test temporarily e2e-tests#1160

[joejstuart]

/retest

[joejstuart]

/retest

[zregvart]

There is an intermittent failure:

build-definitions-pull-request-gzmlf-e2e-tests-pod	  [FAILED] Unexpected error:
build-definitions-pull-request-gzmlf-e2e-tests-pod	      <*errors.errorString | 0xc000e8ce00>: 
build-definitions-pull-request-gzmlf-e2e-tests-pod	      error: unable to access the source layer sha256:79b9c1bf4586875043da099e15dc7963b02ef47f1197a64f1d0db15d52dccdeb: received unexpected HTTP status: 500 Internal Server Error
build-definitions-pull-request-gzmlf-e2e-tests-pod	      {
build-definitions-pull-request-gzmlf-e2e-tests-pod	          s: "error: unable to access the source layer sha256:79b9c1bf4586875043da099e15dc7963b02ef47f1197a64f1d0db15d52dccdeb: received unexpected HTTP status: 500 Internal Server Error",
build-definitions-pull-request-gzmlf-e2e-tests-pod	      }
build-definitions-pull-request-gzmlf-e2e-tests-pod	  occurred
build-definitions-pull-request-gzmlf-e2e-tests-pod	  In [It] at: /github.com/redhat-appstudio/e2e-tests/tests/build/build_templates.go:295 @ 05/08/24 08:00:40.219

And also a potential issue with the test:

build-definitions-pull-request-gzmlf-e2e-tests-pod	  [FAILED] Unexpected error:
build-definitions-pull-request-gzmlf-e2e-tests-pod	      <*errors.errorString | 0xc0019b3b80>: 
build-definitions-pull-request-gzmlf-e2e-tests-pod	      result "IMAGE_URL" not found in TaskRun build-templates-e2e/tkn-bundle-vl7b8
build-definitions-pull-request-gzmlf-e2e-tests-pod	      {
build-definitions-pull-request-gzmlf-e2e-tests-pod	          s: "result \"IMAGE_URL\" not found in TaskRun build-templates-e2e/tkn-bundle-vl7b8",
build-definitions-pull-request-gzmlf-e2e-tests-pod	      }
build-definitions-pull-request-gzmlf-e2e-tests-pod	  occurred
build-definitions-pull-request-gzmlf-e2e-tests-pod	  In [It] at: /github.com/redhat-appstudio/e2e-tests/tests/build/tkn-bundle.go:116 @ 05/08/24 08:01:46.127

The TaskRun seems to have failed with:

Error: could not parse reference: quay.io/redhat-appstudio/test-images:tkn-bundle:tkn-bundle

I can see that the TaskRun parameter IMAGE was provided as such:

    "spec": {
      "params": [
        {
          "name": "IMAGE",
          "value": "quay.io/redhat-appstudio/test-images:tkn-bundle:tkn-bundle"
        },
        {
          "name": "CONTEXT",
          "value": "task2.yaml"
        }
      ],

[joejstuart]

Thanks @zregvart . Here is a PR to address the parsing error https://github.com/redhat-appstudio/e2e-tests/pull/1157/files

[zregvart]

I can see one failed test:

• [FAILED] [21.161 seconds]
[task-suite tkn bundle task] creates Tekton bundles with different params [It] when context points to a file [tasks, HACBS, build-templates-e2e]
/github.com/redhat-appstudio/e2e-tests/tests/build/tkn-bundle.go:164

  Timeline >>
  Waiting for pipeline "tkn-bundle-8wfjc" to finish
  [FAILED] in [It] - /github.com/redhat-appstudio/e2e-tests/tests/build/tkn-bundle.go:127 @ 05/09/24 09:42:34.416
  << Timeline

  [FAILED] taskRun "tkn-bundle-8wfjc" failed
  Expected
      <bool>: false
  to be true
  In [It] at: /github.com/redhat-appstudio/e2e-tests/tests/build/tkn-bundle.go:127 @ 05/09/24 09:42:34.416

From the TaskRun logs:

step-modify-task-files

step-build
*Warning*: This is an experimental command, it's usage and behavior can change in the next release(s)
Creating Tekton Bundle:
	- Added Task: task2 to image
Error: could not push image to registry as "quay.io/redhat-appstudio/test-images:tkn-bundle": POST https://quay.io/v2/redhat-appstudio/test-images/blobs/uploads/: UNAUTHORIZED: access to the requested resource is not authorized; map[]

I can see the TaskRun run with the appstudio-pipeline ServiceAccount and I can see a lot of secrets liked to it, not sure if any one of those has access to push to quay.io/redhat-appstudio/test-images:tkn-bundle. I can see that they're mounted in /tekton/creds-secrets/*, not sure if tkn bundle push will look at those, or if some other Tekton mechanism will combine those to a $HOME/.docker/config.json (or variants) where tkn bundle push will look for credentials to push...

[tisutisu]

@zregvart together two PRs .. PR1 and PR2 should fix the build-definitions CI , which I am testing with this PR .

[joejstuart]

/retest

[joejstuart]

/retest

[joejstuart]

/retest

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

[tisutisu]

failed to create task run pod "build-definitions-pull-request-g7jpj-e2e-tests": translating TaskSpec to Pod: GET https://quay.io/v2/redhat-appstudio/e2e-tests/manifests/b9e71fe4fa3f7cad84b8d71cde1f5501b7deb8f4: MANIFEST_UNKNOWN: manifest unknown; map[]. Maybe invalid TaskSpec

/retest